STYLE: Remove redundant input check from ExtractImageFilter#5319
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 22, 2025
Merged
Conversation
`ExtractImageFilter::GenerateOutputInformation()` has returned already when the input is null. So the "cannot cast input" exception at the end of the member function will never occur anymore. Follow-up to pull request InsightSoftwareConsortium#4608 commit 6650d2c "STYLE: Simplify code to remove unneeded dynamic_cast", Hans Johnson, May 1, 2024
dzenanz
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractImageFilter::GenerateOutputInformation()has returned already when the input is null. So the "cannot cast input" exception at the end of the member function will never occur anymore."STYLE: Simplify code to remove unneeded dynamic_cast", Hans Johnson (@hjmjohnson), May 1, 2024
🤓 When reviewing, it may be helpful to ignore whitespace changes: https://github.com/InsightSoftwareConsortium/ITK/pull/5319/files?w=1
In the original code, you can see that the member function already does
returnearlier, when the input is null:ITK/Modules/Core/Common/include/itkExtractImageFilter.hxx
Lines 109 to 120 in 375ee8c