Отображение закрепления преподавателей за студентами #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriUfimtsev
force-pushed
the
students-assigning-view
branch
from
e9ca1dc to
cd97bd6
Compare
|
@YuriUfimtsev, можешь решить конфликты? |
YuriUfimtsev
force-pushed
the
students-assigning-view
branch
from
cd97bd6 to
d1c01e6
Compare
DedSec256
reviewed
Mar 16, 2025
|
|
||
| namespace HwProj.APIGateway.API.Models.Statistics | ||
| { | ||
| public class AdvancedStatisticsCourseMatesModel |
There was a problem hiding this comment.
точно ли нам нужна совершенно-новая модель?
DedSec256
requested changes
Mar 18, 2025
Comment on lines
257
to
258
| var getMentorsTask = _authServiceClient.GetAccountsData(mentorIds); | ||
| await Task.WhenAll(getMentorsToStudentsTask, getMentorsTask); |
There was a problem hiding this comment.
давай логику получения конкретных аккаунтов не будем выносить за рамки ApiGateway
…eFilterRepository, CourseFilterService, StatisticsController; create new models and dto
YuriUfimtsev
force-pushed
the
students-assigning-view
branch
from
2cf2e36 to
9376665
Compare
DedSec256
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Решение задачи, поставленной в #445.
Отображение имен "закрепленных" преподавателей реализуется в таблице курса.
Фронтенд будет обсуждаться 17 числа, поэтому пока Draft.
UPD: после обсуждения реализован следующий стиль отображения