Ограниченная видимость курсов #593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulat-tsydendorzhiev
commented
May 7, 2025
•
bulat-tsydendorzhiev
commented
- При создании/редактировании курса можно выбрать/поменять опцию "Ограниченно видимый курс" и добавить/изменить описание. Для пояснения опции была добавлена подсказка с пояснением.
- Как выглядит страница, когда на нее переходят незарегистрированные студенты.
…editing a course.
YuriUfimtsev
requested changes
May 7, 2025
Comment on lines
41
to
43
| var hasAccessToMaterials = courseDto.IsOpen | ||
| ? true | ||
| : isCourseStudent; |
There was a problem hiding this comment.
Suggested change
| var hasAccessToMaterials = courseDto.IsOpen | |
| ? true | |
| : isCourseStudent; | |
| var hasAccessToMaterials = courseDto.IsOpen || isCourseStudent; |
| }} | ||
| /> | ||
| } | ||
| label="Ограниченно видимый курс" |
There was a problem hiding this comment.
Suggested change
| label="Ограниченно видимый курс" | |
| label="Ограниченно-видимый курс" |
Comment on lines
102
to
104
| const showMaterialsTab = course.isOpen | ||
| ? true | ||
| : isCourseMentor || isAcceptedStudent |
There was a problem hiding this comment.
Suggested change
| const showMaterialsTab = course.isOpen | |
| ? true | |
| : isCourseMentor || isAcceptedStudent | |
| const showMaterialsTab = course.isOpen || isCourseMentor || isAcceptedStudent |
| @@ -131,7 +132,7 @@ export const CreateCourse: FC = () => { | |||
| const courseViewModel = { | |||
| name: state.courseName, | |||
| groupNames: state.selectedGroups, | |||
| isOpen: true, | |||
| isOpen: !state.isOpen, | |||
| modifiers: [{ name: "offset", options: { offset: [0, -5], } }] | ||
| }} | ||
| title={"Материалы заданий и задач будут доступны только преподавателям и студентам курса"}> | ||
| <IconButton> |
There was a problem hiding this comment.
Давай всю эту галочку вынесем в отдельный компонент, чтобы конфигурацию для неё в двух местах не дублировать
There was a problem hiding this comment.
Хотя лучше поменять текст при создании курса на "Сделать курс ограниченно-видимым", чтобы соотносилось с галочкой выше
|
И добавь, пожалуйста, скриншот, как сейчас будет выглядеть ограниченно-видимый курс. Чтобы страница до интеграции описаний не была совсем уж пустой, можно туда добавить желтое предупреждение, что курс является ограниченно-видимым и для просмотра материалов необходимо на него записаться |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.