discrete gaussian: avoid float overflow #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. Here, `b_std` is being squared, and the product could overflow its type `float` before it is assigned to the `double` `variance`. To prevent the overflow, `b_std` is cast to `double` before performing the multiplication. on-behalf-of: @permanence-ai [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. Here,
b_stdis being squared, and the product could overflow its typefloatbefore it is assigned to thedoublevariance. To prevent the overflow,b_stdis cast todoublebefore performing the multiplication.on-behalf-of: @permanence-ai [email protected]