dcrtpoly-impl: avoid integer overflow #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. Here, there are several products of 32-bit integers that are later promoted to a larger type. The result could overflow 32 bits before the promotion. - `n * numQ` used as the initial size of a vector - `n * numBsk` used as the initial size for a vector - `j * n + k` used as an index into `txiqiDivqModqi` In each case, the values to be multiplied are cast to `size_t` first to avoid the potential overflow. on-behalf-of: @permanence-ai [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR were automatically generated by the Permanence AI Coder and reviewed by @eelenberg and @jweese. Here, there are several products of 32-bit integers that are later promoted to a larger type. The result could overflow 32 bits before the promotion.
n * numQused as the initial size of a vectorn * numBskused as the initial size for a vectorj * n + kused as an index intotxiqiDivqModqiIn each case, the values to be multiplied are cast to
size_tfirst to avoid the potential overflow.on-behalf-of: @permanence-ai [email protected]