Skip to content

Bug Fix: Sub Kernel issue with input0/1 ordering. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Bug Fix: Sub Kernel issue with input0/1 ordering. #120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e73f1fd
Bug fix for Sub kernel. Issue: CartesianOp assumed commutative operat…
christopherngutierrez Aug 18, 2025
9cbbe81
Merge branch 'main' into christopherngutierrez/sub-bug-fix
christopherngutierrez Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions p-isa_tools/kerngen/pisa_generators/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,18 @@ def to_pisa(self) -> list[PIsaOp]:
# Not the same number of parts
first, second = (self.input0, self.input1) if self.input0.parts < self.input1.parts else (self.input1, self.input0)

# Preserve the ordering of the inputs (output = input0 op input1) to avoid issues with non-commutative ops (e.g. sub)
# For example input0 - input1 != input1 - input0
order_preserved = first == self.input0

ls: list[PIsaOp] = []
for unit, q in it.product(range(self.context.units), range(self.input0.start_rns, self.input0.rns)):
ls.extend(
self.op(
self.context.label,
self.output(part, q, unit),
first(part, q, unit),
second(0, q, unit),
first(part, q, unit) if order_preserved else second(0, q, unit),
second(0, q, unit) if order_preserved else first(part, q, unit),
q,
)
for part in range(first.parts)
Expand Down