Skip to content

Resolve gh-2055 #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Resolve gh-2055 #2058

wants to merge 3 commits into from

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 17, 2025

This PR fixes a bug in asarray where order="K" keyword could fail to produce an appropriate array in some edge cases, such as the permutation of a contiguous array.

asarray(x) for some NumPy array x now uses a consistent implementation for order="K" as other functions supporting order

Closes #2055

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_147 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

1 similar comment
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_147 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Apr 17, 2025

Coverage Status

coverage: 86.42% (+0.01%) from 86.41%
when pulling 93d288c on resolve-gh-2055
into 3e74087 on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review April 21, 2025 21:43
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_153 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpt.asarray failed to copy input numpy.ndarray
2 participants