Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove w/a related to dpctl-issue-2030 #2403

Merged
merged 10 commits into from
Apr 9, 2025
Merged

remove w/a related to dpctl-issue-2030 #2403

merged 10 commits into from
Apr 9, 2025

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Mar 31, 2025

Removes w/a related to IntelPython/dpctl#2030.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@vtavana vtavana self-assigned this Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_81 ran successfully.
Passed: 1215
Failed: 0
Skipped: 14

@antonwolfy antonwolfy mentioned this pull request Apr 2, 2025
Merged
7 tasks
antonwolfy added a commit that referenced this pull request Apr 2, 2025
@antonwolfy
Disable w/a for dpctl-2030 on CPU device (#2405)
434156d 
The PR proposes to partly merge changes from #2403 to unblock coverage
GitHub action.
The workaround for dpctl-2030 was kept only for testing with GPU device
(the use case from internal CI, where the changes from dpctl-2030 is not
available).
github-actions bot added a commit that referenced this pull request Apr 2, 2025
@github-actions
Disable w/a for dpctl-2030 on CPU device (#2405)
0214627 
The PR proposes to partly merge changes from #2403 to unblock coverage
GitHub action.
The workaround for dpctl-2030 was kept only for testing with GPU device
(the use case from internal CI, where the changes from dpctl-2030 is not
available). 434156d
@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2025 •
edited
Loading

Coverage Status

coverage: 72.271%. remained the same
when pulling ba30819 on remove-workaraound-dpctl-2030
into 777bc73 on master.

antonwolfy
antonwolfy approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are ready to merge that

@vtavana vtavana marked this pull request as ready for review April 9, 2025 16:36
@vtavana vtavana merged commit 5daa7e9 into master Apr 9, 2025
68 checks passed
@vtavana vtavana deleted the remove-workaraound-dpctl-2030 branch April 9, 2025 20:45
github-actions bot added a commit that referenced this pull request Apr 9, 2025
@github-actions
remove w/a related to dpctl-issue-2030 (#2403)
f4da349 
Removes w/a related to IntelPython/dpctl#2030.

---------

Co-authored-by: Anton <[email protected]> 5daa7e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov AlexanderKalistratov is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtavana @coveralls @ndgrigorian @antonwolfy