-
Notifications
You must be signed in to change notification settings - Fork 23
Use oneMKL LAPACK gesv
for dpnp.linalg.solve()
#2558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e482aae
to
3d737dc
Compare
View rendered docs @ https://intelpython.github.io/dpnp/pull/2558/index.html |
Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_15 ran successfully. |
Coverage decrease is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be having stability issues on Level Zero, internal CI shows it in TestSolve
@vlad-perevezentsev can you investigate if this is acceptable level of error and loosen the test if it is, and otherwise, look at it?
@ndgrigorian Thank you for noticing this! |
This PR suggests using oneMKL LAPACK
gesv
instead ofgetrf
andgetrs
indpnp.linalg.solve()
since the issues in oneMKL have been resolved. This removes the workaround implemented in #1763