Skip to content

use PyLong_AsLong instead of PyInt_AsLong #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 13, 2025

PyInt_AsLong is deprecated and PyLong_AsLong should be used with python3.

@vtavana vtavana self-assigned this May 13, 2025
@vtavana vtavana force-pushed the use-PyLong_AsLong branch from d39a77d to b86036b Compare May 13, 2025 17:46
@vtavana vtavana marked this pull request as ready for review May 14, 2025 03:18
@Copilot Copilot AI review requested due to automatic review settings May 14, 2025 03:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the conda packaging workflows to adjust dependency installation steps and environment creation commands. Key changes include:

  • Splitting the environment creation and package installation steps.
  • Removing "pytest-cov" from the test dependencies configuration.
  • Aligning dependency version specifications for scipy.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/conda-package.yml Modified environment creation and restructured package installation; removed "pytest-cov".
.github/workflows/conda-package-cf.yml Updated test dependency settings and adjusted installation arguments similarly.
Files not reviewed (1)
  • mkl_fft/_pydfti.pyx: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/conda-package.yml:299

  • [nitpick] The removal of 'pytest-cov' from TEST_DEPENDENCIES may affect test coverage reporting. If this change is intentional, please confirm that test coverage is handled elsewhere.
SET "TEST_DEPENDENCIES=pytest scipy"

.github/workflows/conda-package-cf.yml:298

  • [nitpick] The removal of 'pytest-cov' from TEST_DEPENDENCIES might impact code coverage collection. Ensure that this change aligns with the intended testing strategy.
SET "TEST_DEPENDENCIES=pytest scipy"

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Given that it was part of Python 2 C API I'm surprised it was ever even used

@vtavana vtavana merged commit 675bd8b into master May 15, 2025
57 checks passed
@vtavana vtavana deleted the use-PyLong_AsLong branch May 15, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants