chore: bump interaction-design-foundation/coding-standard to ^1.0-RC1 - #76
chore: bump interaction-design-foundation/coding-standard to ^1.0-RC1#76alies-dev wants to merge 3 commits into
Conversation
Replace standalone friendsofphp/php-cs-fixer and squizlabs/php_codesniffer with the shared IxDF coding standard package. Update .php-cs-fixer.php to use the shared Config factory and phpcs.xml to reference IxDFCodingStandard.
Auto-fixed violations detected by the new IxDF coding standard. Kept HttpClient and AbstractService::boot() non-final to preserve testability and extensibility.
Apply resulting php-cs-fixer changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the package's coding standards to use the Interaction Design Foundation coding standard, resulting in widespread formatting and styling changes across the codebase. However, several critical issues were identified in the review: making the boot() method final in AbstractService will cause a PHP Fatal Error as subclasses override it; using mb_substr in HttpClient to split headers and body based on a byte-count offset can lead to data corruption; and using mb_trim will cause fatal errors on PHP versions prior to 8.4.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| public function boot(): void | ||
| { | ||
| } | ||
| final public function boot(): void {} |
There was a problem hiding this comment.
Making the boot() method final in the abstract class AbstractService will cause a PHP Fatal Error because subclasses like MaxMindDatabase, IPGeoLocation, and IPApi override this method to perform their own initialization.
Please remove the final keyword from the boot() method.
public function boot(): void {}| $header = mb_substr($response, 0, $header_size); | ||
| $body = mb_substr($response, $header_size); |
There was a problem hiding this comment.
Using mb_substr here is incorrect and can lead to data corruption or malformed HTTP parsing.
curl_getinfo($curl, CURLINFO_HEADER_SIZE) returns the header size in bytes, not characters. substr is a byte-safe function, whereas mb_substr is character-encoding-aware. If the HTTP response headers or the beginning of the body contain any multibyte characters, mb_substr will split the string at the wrong byte offset, resulting in corrupted headers or body.
Please revert this change to use the byte-safe substr function.
$header = substr($response, 0, $header_size);
$body = substr($response, $header_size);|
|
||
| if (count($header) === 2) { | ||
| $result[$header[0]] = trim($header[1]); | ||
| $result[$header[0]] = mb_trim($header[1]); |
There was a problem hiding this comment.
The mb_trim function was introduced in PHP 8.4. Since this package specifies a minimum PHP version of ^8.2 in composer.json, calling mb_trim directly will result in a Fatal Error: Call to undefined function mb_trim() on PHP 8.2 and 8.3 environments.
Since HTTP headers are ASCII-compatible, the standard trim function is perfectly safe and fully compatible. Please revert this to trim.
$result[$header[0]] = trim($header[1]);1 participant
Bump coding-standard to ^1.0-RC1 and apply resulting php-cs-fixer changes.