Skip to content

Replace version compatibility error with a warning #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anredlich wants to merge 1 commit into
base: trossen-ai
Choose a base branch
from
Open

Replace version compatibility error with a warning #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lerobot/common/datasets/lerobot_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from huggingface_hub.errors import RevisionNotFoundError

from lerobot.common.constants import HF_LEROBOT_HOME
from lerobot.common.datasets.backward_compatibility import SubVersionBackwardCompatibilityError
from lerobot.common.datasets.backward_compatibility import SubVersionBackwardCompatibilityError,TROSSEN_V1_MESSAGE #added TROSSEN_V1_MESSAGE
from lerobot.common.datasets.compute_stats import aggregate_stats, compute_episode_stats
from lerobot.common.datasets.image_writer import AsyncImageWriter, write_image
from lerobot.common.datasets.utils import (
Expand Down Expand Up @@ -110,7 +110,7 @@ def load_metadata(self):
if not self.edit_mode:
check_version_compatibility(self.repo_id, self._version, CODEBASE_VERSION)
check_version_compatibility(
self.repo_id, self._subversion, TROSSEN_SUBVERSION, is_subversion=True
self.repo_id, self._subversion, TROSSEN_SUBVERSION, is_subversion=True, enforce_breaking_major = False #added enforce_breaking_major = False
)
self.tasks, self.task_to_task_index = load_tasks(self.root)
self.episodes = load_episodes(self.root)
Expand Down Expand Up @@ -144,7 +144,9 @@ def _version(self) -> packaging.version.Version:
def _subversion(self) -> packaging.version.Version:
"""Trossen subversion used to create this dataset."""
if "trossen_subversion" not in self.info:
raise SubVersionBackwardCompatibilityError(self.repo_id, "v0.0")
#raise SubVersionBackwardCompatibilityError(self.repo_id, "v0.0") #no longer raise error
logging.warning(TROSSEN_V1_MESSAGE.format(repo_id=self.repo_id, version="v0.0")) #warning instead
return packaging.version.parse("v0.0") # return a default version instead of raising error #anr added
sub_version = self.info["trossen_subversion"]
return packaging.version.parse(sub_version)

Expand Down