feat: use line endings of the file instead of the system#11
Open
patrickhoogkamer wants to merge 1 commit intomainfrom
Open
feat: use line endings of the file instead of the system#11patrickhoogkamer wants to merge 1 commit intomainfrom
patrickhoogkamer wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
force-pushed
the
detect-line-endings
branch
from
56b3752 to
39d1476
Compare
patrickhoogkamer
force-pushed
the
detect-line-endings
branch
from
39d1476 to
1f5173b
Compare
patrickhoogkamer
force-pushed
the
detect-line-endings
branch
from
1f5173b to
947ec34
Compare
Contributor
|
Can you add a test? Maybe the test data you create in the current test can be a concatenated string with different line endings written out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might fix line ending issues when using a Windows PHP executable where PHP_EOL would be
\r\nbut the file would use\n. And vice versa on MacOS/Linux.