Skip to content

New asTypeFromValue function #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

newhoggy
Copy link
Collaborator

Changelog

- description: |
    New `asTypeFromValue` function
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@@ -22,5 +23,8 @@ class Typeable t => HasTypeProxy t where

proxyToAsType :: Proxy t -> AsType t

asTypeFromValue :: HasTypeProxy t => t -> AsType t
asTypeFromValue _ = proxyToAsType Proxy

Copy link
Contributor

@carbolymer carbolymer Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be useful too:

Suggested change
asType :: HasTypeProxy t => AsType t
asType = proxyToAsType Proxy

@@ -6,6 +6,7 @@ module Cardano.Api.Internal.HasTypeProxy
( HasTypeProxy (AsType, proxyToAsType)
, Proxy (..)
, FromSomeType (..)
, asTypeFromValue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you have to export it from Cardano.Api as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants