Skip to content

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Sep 16, 2025

Changelog

- description: |
    Disable Alonzo Genesis cost models validation, since it is done by ledger now
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
# uncomment at least one main project this PR is associated with
  projects:
   - cardano-api
  # - cardano-api-gen
  # - cardano-rpc
  # - cardano-wasm

Context

This PR targets node-10.6 release PR: #954

This PR removes validation introduced in:

The validation becomes redundant, because the ledger validation for cost model params became more strict, and an additional validation in cardano-api is no longer needed.

Relevant change in ledger:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/fix/disable-alonzo-genesis-validation branch 2 times, most recently from 7bb8842 to 7ba22bc Compare September 17, 2025 13:32
@carbolymer carbolymer requested a review from a team as a code owner September 17, 2025 13:32
@carbolymer carbolymer force-pushed the jordan/10.6-node-release branch from 80ade3c to ca7297f Compare September 17, 2025 13:34
@carbolymer carbolymer force-pushed the mgalazyn/fix/disable-alonzo-genesis-validation branch 3 times, most recently from 3ebc40b to ab839f1 Compare September 19, 2025 15:51
@carbolymer carbolymer force-pushed the mgalazyn/fix/disable-alonzo-genesis-validation branch from ab839f1 to 9e494aa Compare September 19, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant