Add SerialiseAsCBOR instance for TxOut
#960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
CarlosLopezDeLara,
Jimbo4350,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond and
newhoggy
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
palas
force-pushed
the
SerialiseAsCBOR-for-TxOut
branch
from
e9c48c5 to
753f06b
Compare
carbolymer
requested changes
Sep 22, 2025
palas
force-pushed
the
SerialiseAsCBOR-for-TxOut
branch
from
753f06b to
fe0c24c
Compare
palas
force-pushed
the
SerialiseAsCBOR-for-TxOut
branch
from
fe0c24c to
bdb5761
Compare
carbolymer
reviewed
Oct 22, 2025
carbolymer
reviewed
Oct 22, 2025
carbolymer
reviewed
Oct 22, 2025
palas
force-pushed
the
SerialiseAsCBOR-for-TxOut
branch
2 times, most recently
from
07aa3fe to
8a17ba1
Compare
palas
force-pushed
the
SerialiseAsCBOR-for-TxOut
branch
from
8a17ba1 to
2f1e19c
Compare
carbolymer
reviewed
Oct 24, 2025
| pure (fromShelleyTxOut shelleyBasedEra) <*> L.fromEraCBOR @(ShelleyLedgerEra era) | ||
|
|
||
| -- | We do not provide a 'ToCBOR' instance for 'TxOut' because 'TxOut's can | ||
| -- contain supplemental datums and the CBOR representation does not support this. |
There was a problem hiding this comment.
Suggested change
| -- contain supplemental datums and the CBOR representation does not support this. | |
| -- contain supplemental datums and the ledger's CBOR representation does not support this. |
carbolymer
approved these changes
Oct 24, 2025
Jimbo4350
reviewed
Oct 24, 2025
| , IsShelleyBasedEra era | ||
| ) | ||
| => ToCBOR (TxOut ctx era) | ||
| where |
There was a problem hiding this comment.
Why bother providing a ToCBOR instance? A comment above the FromCBOR instance should be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR addresses #955.
How to trust this PR
The test should help with trust. But there is a bit of an issue with
ToCBORinstance losing information, so there is a design decision to be make about this. Please, let me know what you think about this.Checklist