Skip to content

Conversation

perturbing
Copy link
Collaborator

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@perturbing perturbing force-pushed the perturbing/add-bls-sig-bindings branch from ce400c0 to 8e15235 Compare September 17, 2025 12:20
forall curve.
BLS.FinalVerifyOrder curve =>
String -> Proxy curve -> TestTree
testBlsPoP name _ =
Copy link
Collaborator Author

@perturbing perturbing Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that I do not forget, these tests should also include test vectors from an external source (similar to what we did for the BLS tests). These should check alignment of the dst and aug and extra key material as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant