change Size prefix to suffix in DSIGN
#610
Open
+402
−316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perturbing
force-pushed
the
perturbing/fix-dsign-size-suffix
branch
4 times, most recently
from
d01b6dd to
f175eee
Compare
lehins
requested changes
Jan 24, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
I love it! ❤️
Aside from reverting addition of type synonyms in favor keeping them as associated type families, as well as expanding on the changelogs this is good to go.
perturbing
force-pushed
the
perturbing/fix-dsign-size-suffix
branch
from
f175eee to
59868c4
Compare
lehins
approved these changes
Jan 27, 2026
Collaborator
lehins
left a comment
lehins
left a comment
There was a problem hiding this comment.
Needs a rebase and it is good to be merged.
Made one comment about the changelog, but that is not the end of the world if not addressed, since type families are listed
Thank you.
perturbing
force-pushed
the
perturbing/fix-dsign-size-suffix
branch
from
59868c4 to
92d93f6
Compare
Member
Author
|
Did the rebase and added the missing mention of the deprecated functions to the changelog (I only had the types). Thanks for the review and help! |
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
Co-authored-by: Alexey Kuleshevich <[email protected]>
perturbing
force-pushed
the
perturbing/fix-dsign-size-suffix
branch
from
92d93f6 to
6216903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #602
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)