Store delegators in pool state #5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
12 times, most recently
from
b86f5cb to
e358c21
Compare
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
13 times, most recently
from
4dea23b to
f44c36b
Compare
teodanciu
changed the title
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
2 times, most recently
from
7cf8b76 to
47d319c
Compare
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
2 times, most recently
from
57b2852 to
a75026f
Compare
|
I addressed your suggestions, @lehins - whenever you have time to have another look. |
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
from
a75026f to
6cc9851
Compare
lehins
approved these changes
Oct 29, 2025
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/DelegSpec.hs
Outdated
Show resolved
Hide resolved
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
6 times, most recently
from
ea55751 to
5ac7675
Compare
for consistency
and add a test case for redelegating drep
and add a test for it
and add a test for it
uniformly across eras
in order not to lose the delegations that happened after the update, before the end of the epoch
teodanciu
force-pushed
the
td/store-delegs-in-stakepoolstate
branch
from
485541f to
5197446
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Store, in each pool's StakePoolState, the stake credentials that have delegated to that pool.
This set is updated in DELEG rule, for both shelley and conway:
The set is used to improve the performance of removing delegations when retiring the pool.
Based on PR: #5330
Closes: #4990
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).