Skip to content

Conversation

@lehins
Copy link
Collaborator

@lehins lehins commented Oct 28, 2025

Description

This bug manifested itself in current pool parameters being returned instead of the future ones.

This fix is needed for cardano-node-10.6 release, as such it is also backported in this #5366

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@lehins lehins requested a review from a team as a code owner October 28, 2025 00:44
@lehins lehins requested a review from aniketd October 28, 2025 00:47
@lehins lehins mentioned this pull request Oct 28, 2025
10 tasks
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you need a change to make it compile.

@lehins lehins force-pushed the lehins/fix-pool-params-query branch 2 times, most recently from ef255ff to b5ec6eb Compare October 28, 2025 22:03
@lehins lehins enabled auto-merge October 28, 2025 22:03
This bug manifested itself in current pool parameters being returned
instead of the future ones.
@lehins lehins force-pushed the lehins/fix-pool-params-query branch from b5ec6eb to b56aa41 Compare October 29, 2025 02:17
@lehins lehins merged commit 6f1b0b2 into master Oct 29, 2025
119 of 122 checks passed
@lehins lehins deleted the lehins/fix-pool-params-query branch October 29, 2025 04:09
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants