Add symbolic logging to cardano-tracer #6125
Draft
+399
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icelandjack
force-pushed
the
baldurb/symlink
branch
from
d173839 to
41d5393
Compare
Icelandjack
force-pushed
the
baldurb/symlink
branch
19 times, most recently
from
f82d303 to
6d25d88
Compare
Icelandjack
force-pushed
the
baldurb/symlink
branch
3 times, most recently
from
d24c23d to
fcc7d97
Compare
Icelandjack
force-pushed
the
baldurb/symlink
branch
5 times, most recently
from
671e209 to
3d6f737
Compare
mgmeier
reviewed
Mar 31, 2025
| -> [PeerT blk] | ||
| -> IO () | ||
| traceNodePeers tr ev = traceWith tr $ NodePeers (fmap ppPeer ev) | ||
|
|
There was a problem hiding this comment.
double-check: can that be rmoved?
There was a problem hiding this comment.
Yes this was safely removed.
mgmeier
reviewed
Mar 31, 2025
cardano-tracer/CHANGELOG.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # ChangeLog | |||
|
|
|||
| ## 0.3.2 (March 31, 2025) | |||
mgmeier
reviewed
Mar 31, 2025
trace-dispatcher/CHANGELOG.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Revision history for trace-dispatcher | |||
|
|
|||
|
|
|||
| ## 2.8.2 (March 31, 2025) | |||
There was a problem hiding this comment.
defer version bump until after 10.3 release
|
Please update PR description + title. Leave as draft until Node 10.3 release on |
Icelandjack
force-pushed
the
baldurb/symlink
branch
14 times, most recently
from
dffe5fb to
78297ba
Compare
Icelandjack
force-pushed
the
baldurb/symlink
branch
from
fe6ccda to
7c1acf3
Compare
Icelandjack
force-pushed
the
baldurb/symlink
branch
from
7c1acf3 to
d5fe4dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes 3 separate commits:
cardano-tracer: Eliminatecardano-nodedependency.cardano-tracer: Hide mkTimer module, change STM to IORef (fixes issue "Leaky thread in mkTimer").cardano-node:Make rpMaxAgeMinutes optional.Checklist
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.