Skip to content

Only accept CC if minsize and threshold are both zero #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Only accept CC if minsize and threshold are both zero #975

wants to merge 2 commits into from

Conversation

@Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 4, 2025 •
edited
Loading

Description

This PR changes how CC votes are counted in the case where there aren't enough CC members and the threshold is zero. According to the discussion in IntersectMBO/cardano-ledger#5170, CC should accept only if both the ccMinSize and threshold are set to zero.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw changed the title Only ratify CC if minsize and threshold are both zero Only accept CC if minsize and threshold are both zero Nov 4, 2025
@Soupstraw Soupstraw requested a review from carlostome November 4, 2025 15:42
@Soupstraw Soupstraw marked this pull request as ready for review November 4, 2025 15:42
@carlostome
Copy link
Collaborator

carlostome commented Nov 4, 2025 •
edited
Loading

The cardano-ledger test from IntersectMBO/cardano-ledger#5184 is still failing after these changes.

@Soupstraw Soupstraw marked this pull request as draft November 5, 2025 10:22
@Soupstraw Soupstraw marked this pull request as ready for review November 5, 2025 12:17
@Soupstraw
Copy link
Contributor Author

Soupstraw commented Nov 5, 2025

Turns out there was another bug as well. The ccMinSize was checked against all the CC members, not just the active ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlostome carlostome Awaiting requested review from carlostome

@williamdemeo williamdemeo Awaiting requested review from williamdemeo

@WhatisRT WhatisRT Awaiting requested review from WhatisRT

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Soupstraw @carlostome