Define transferRegistry for transferring a whole registry
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/ingest
branch
2 times, most recently
from
d934cb4 to
2d86e1c
Compare
geo2a
reviewed
Oct 21, 2025
bladyjoker
reviewed
Oct 21, 2025
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Left some comments but fyi I don't know much about the library so feel free to ignore me :)
geo2a
previously approved these changes
Oct 21, 2025
geo2a
left a comment
geo2a
left a comment
There was a problem hiding this comment.
The PR looks fine, I've left some wording and refactoring suggesting. Approving to unblock, but please address my comment about allocNKeys.
geo2a
dismissed
their stale review
After reading Drazen's review, I've decided to withdraw my approval, as I now think that we could get rig of the RegistryStateresourceTransferredContext field.
jasagredo
force-pushed
the
js/ingest
branch
2 times, most recently
from
c847211 to
025a948
Compare
geo2a
approved these changes
Oct 21, 2025
geo2a
left a comment
geo2a
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments @jasagredo!
jasagredo
changed the title
ingestRegistry for transferring a whole registrytransferRegistry for transferring a whole registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows a registry to be swallowed into another registry.