Add support for new ledger state query GetDRepDelegations in NodeToClientV_23 #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
Contributor
Author
|
This PR is blocked because it requires an integration of ouroboros-network latest main into consensus. |
jasagredo
force-pushed
the
js/ktorz/GetDRepDelegations
branch
from
4728551 to
f37288d
Compare
The new method leverages a corresponding method recently exposed by ledger side to provide encoded transaction sizes to eg. diffusion layer. - Integrate new tx submission protocol - txWireSize: Byron txs overhead We need to add 2 bytes overhead for `EncCBOR (AMempoolPayload ByteString)`. See: https://github.com/IntersectMBO/cardano-ledger/blob/cardano-ledger-byron-1.1.0.0/eras/byron/ledger/impl/src/Cardano/Chain/MempoolPayload.hs#L73-L81 - txWireSize: wrapCBORinCBOR overhead for Shelley txs - Take into account the overhead of `wrapCBORinCBOR`. - txWireSize: added overhead for HardFork txs - Added HFC overhead. This overestimates it, if the HFC is disabled. - txWireSize: added tests - Use txWireSize when computing tx-sizes for ouroboros-network Co-Author: Armando Santos <[email protected]> Co-Author: Marcin Szamotulski <[email protected]> Co-Author: Marcin Wójtowicz <[email protected]>
[wip] bump network
jasagredo
force-pushed
the
js/ktorz/GetDRepDelegations
branch
from
f37288d to
1feaeba
Compare
jasagredo
changed the base branch from
main
to
geo2a/10.7-integration-network
jasagredo
force-pushed
the
js/ktorz/GetDRepDelegations
branch
from
1feaeba to
971adbd
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
2 times, most recently
from
ce178b5 to
ff3072d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR wires in a new ledger state query that was recently added but never got properly wired in.
This PR requires IntersectMBO/ouroboros-network#5222 due to the nice dependency on the network version there 😬.
Note that I do expect some help getting this merged. The repository is complex to build, and I kindly refuse to use Nix. So if anything goes wrong with CI, I would appreciate a little nudge from the maintainers to getting this through. It's been living on a fork of mine for a while, yet I can't properly make this available to end users in Ogmios without "official" support for it in the node.
Thanks.