Network integration for cardano-node 10.7
#1819
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
3 times, most recently
from
f020af8 to
49cd4cb
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
2 times, most recently
from
2f2d063 to
2e1436c
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
3 times, most recently
from
2ca3ec3 to
956b131
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
3 times, most recently
from
46a5db2 to
4614065
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
6 times, most recently
from
fb37549 to
432f587
Compare
Contributor
Author
|
@copilot review the changes per package and compose changelog items for every package. |
geo2a
changed the title
cardano-node 10.7cardano-node 10.7
geo2a
requested review from
bladyjoker,
dnadales,
fraser-iohk,
jasagredo and
nfrisby
as code owners
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
432f587 to
c9a1aae
Compare
jasagredo
reviewed
Jan 29, 2026
Comment on lines
21
to
22
| - New `CardanoNodeToClientVersion19` | ||
| - New `ShelleyNodeToClientVersion15` |
Contributor
There was a problem hiding this comment.
Maybe make this a bit more verbose, I wrote it that way to just give a skeleton but I didn't mean to write it this succint in the changelog 😄
Contributor
Author
There was a problem hiding this comment.
I've looked at other similar items and updated this one accordingly.
| GenesisPoint -> k (pure Nothing) | ||
| (BlockPoint targetSlot (SomeHashableBlock _ targetHash)) -> do | ||
| case (cast targetHash :: Maybe (HeaderHash blk)) of | ||
| Nothing -> error "impossible! Distinct (HeaderHash blk) types" |
Contributor
There was a problem hiding this comment.
Why do we need an existential for SomeHashableBlock?
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
bbbdefc to
9962633
Compare
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
f9f7f24 to
9e9fadd
Compare
jasagredo
reviewed
Jan 30, 2026
Comment on lines
42
to
43
| , testProperty "GenTx.txWireSize.txSubmission" (prop_txWireSize_txSubmission testCodecCfg) | ||
| , testProperty "GenTx.txWireSize.tight" (prop_txWireSize (const Nothing) testCodecCfg) |
|
|
||
| - Added `txLogicTracer` and `txCountersTrace` to `Tracers'`. | ||
| - Added `rnTxSubmissionLogicVersion` and `rnTxSubmissionInitDelay` fields to `RunNodeArgs`. | ||
| - Added new `getTxChannelsVar`, `getSharedTxStateVar` and `getTxMempoolSem` variables to `NodeKernel`. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Added new `getTxChannelsVar`, `getSharedTxStateVar` and `getTxMempoolSem` variables to `NodeKernel`. | |
| - Added new `getTxChannelsVar`, `getSharedTxStateVar` and `getTxMempoolSem` fields to `NodeKernel`. |
| , blockFetchPipeliningMax = 10 | ||
| , txSubmissionMaxUnacked = 1000 -- TODO ? | ||
| , txDecisionPolicy = | ||
| defaultTxDecisionPolicy{maxUnacknowledgedTxIds = 1000} -- TODO ? |
Contributor
There was a problem hiding this comment.
Who introduced this TODO? Is it still relevant?
Contributor
Author
There was a problem hiding this comment.
@coot do you think it would be OK to remove this TODO?
Contributor
|
Please apply this patch that modifes the build-depends to remove the unnecessary curly braces |
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
ac06030 to
ce178b5
Compare
The new method leverages a corresponding method recently exposed by ledger side to provide encoded transaction sizes to eg. diffusion layer. - Integrate new tx submission protocol - txWireSize: Byron txs overhead We need to add 2 bytes overhead for `EncCBOR (AMempoolPayload ByteString)`. See: https://github.com/IntersectMBO/cardano-ledger/blob/cardano-ledger-byron-1.1.0.0/eras/byron/ledger/impl/src/Cardano/Chain/MempoolPayload.hs#L73-L81 - txWireSize: wrapCBORinCBOR overhead for Shelley txs - Take into account the overhead of `wrapCBORinCBOR`. - txWireSize: added overhead for HardFork txs - Added HFC overhead. This overestimates it, if the HFC is disabled. - txWireSize: added tests - Use txWireSize when computing tx-sizes for ouroboros-network Co-Author: Armando Santos <[email protected]> Co-Author: Marcin Szamotulski <[email protected]> Co-Author: Marcin Wójtowicz <[email protected]>
amend todo
[wip] bump network
geo2a
force-pushed
the
geo2a/10.7-integration-network
branch
from
ce178b5 to
ff3072d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ouroboros-netowork-24and a little bit beyond.kes-agent-1.1. Removes the s-r-p onkes-agentrepository.