Skip to content

Make plutus compile with both QuickCheck 2.15.. and 2.16 #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2025
Merged

Make plutus compile with both QuickCheck 2.15.. and 2.16 #7314

merged 2 commits into from
Sep 10, 2025

Conversation

ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie self-assigned this Sep 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025 •
edited
Loading

PR Preview Action v1.6.2

🚀 View preview at
https://IntersectMBO.github.io/plutus/pr-preview/pr-7314/

Built to branch gh-pages at 2025-09-08 12:02 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@ana-pantilie ana-pantilie added the No Changelog Required Add this to skip the Changelog Check label Sep 5, 2025
@ana-pantilie ana-pantilie requested a review from a team September 5, 2025 13:58
zliu41
zliu41 requested changes Sep 5, 2025
View reviewed changes
Copy link
Member

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to do import Test.QuickCheck hiding (Some (..)), along with {-# OPTIONS_GHC -Wno-dodgy-imports #-}

@ana-pantilie ana-pantilie requested a review from zliu41 September 8, 2025 12:12
@ana-pantilie ana-pantilie changed the title Add QuickCheck upper bound in plutus-core Make plutus compile with both QuickCheck 2.15 and 2.16 Sep 8, 2025
@ana-pantilie ana-pantilie changed the title Make plutus compile with both QuickCheck 2.15 and 2.16 Make plutus compile with both QuickCheck 2.15.1 and 2.16 Sep 8, 2025
@ana-pantilie ana-pantilie changed the title Make plutus compile with both QuickCheck 2.15.1 and 2.16 Make plutus compile with both QuickCheck 2.15.. and 2.16 Sep 8, 2025
@ana-pantilie ana-pantilie enabled auto-merge (squash) September 8, 2025 14:37
@ana-pantilie ana-pantilie merged commit 13ff994 into master Sep 10, 2025
22 checks passed
@ana-pantilie ana-pantilie deleted the ana/upperbound-quickcheck branch September 10, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliu41 zliu41 zliu41 approved these changes

@zeme-wana zeme-wana zeme-wana approved these changes

Assignees

@ana-pantilie ana-pantilie

Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ana-pantilie @zliu41 @zeme-wana