fix(wgpu): allow null HINSTANCE for parented Windows editors - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why\nbaseview exposes only an HWND for parented Windows plug-in editors. The WGPU raw-handle bridge attempted to unwrap a null HINSTANCE as NonZeroIsize, panicking before surface creation.\n\n## Change\nPreserve a null HINSTANCE in raw-window-handle 0.6 and add a regression test.\n\n## Verification\n-
running 1 test
test renderer::wgpu::renderer::tests::parented_win32_handle_allows_a_null_hinstance ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s (1 passed)\n- ENZYME Windows VST3/CLAP release built on qemu Win10 and its Reaper editor rendered successfully after this fix.