Code style improvements #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a number of changes regarding code style: - The Intrepid code style is now checked into version control - All files are reformatted using the updated style - Add ktlint to do basic style check, it will be run as part of prCheck - Add editorConfig to automatically add/enforce line feed at end of file
f2rf2r
requested review from
gdaniels,
mpeng3,
russhwolf,
shadow7 and
streetsofboston
mpeng3
reviewed
Jul 15, 2019
Contributor
mpeng3
left a comment
mpeng3
left a comment
There was a problem hiding this comment.
This looks fine to me, but I would ask - if we can't use it with the latest fully released version of Android Studio due to the bug that you mentioned, perhaps we should hold off merging this in until Android Studio 3.5 is released? What do other people think about this?
Member
Author
|
yeah I'm holding off on merging this until 3.5 is released and verified to work correctly |
shadow7
reviewed
Oct 10, 2019
|
|
||
| //https://github.com/mockk/mockk/issues/281 | ||
| ktlint { | ||
| version.set("0.33.0") |
shadow7
reviewed
Oct 10, 2019
| classpath("com.squareup.spoon:spoon-runner:2.0.0-SNAPSHOT") // TODO update/remove this once spoon 2.0.0 is stable | ||
| classpath("io.fabric.tools:gradle:1.26.1") | ||
| classpath("gradle.plugin.io.intrepid:static-analysis:1.2.2") | ||
| classpath("org.jlleitschuh.gradle:ktlint-gradle:8.0.0") |
shadow7
approved these changes
Oct 10, 2019
shadow7
left a comment
shadow7
left a comment
There was a problem hiding this comment.
Looks like the bug blocking this was resolved. Just denoted a couple dependencies that have been upgraded in that time
Member
Author
|
I tested this with 3.5 and Android Studio is still having problem importing the project have .idea folder partially checked in while using kts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a number of changes regarding code style:
Currently, having the idea folder partially checked in while using kotlin dsl for the top level build.gradle causes the project to not import correctly in Android Studio 3.4, it should be fixed in 3.5. gradle/kotlin-dsl-samples#1166