Feat: USDe before maturity feed with NAV #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xtj24
commented
Mar 12, 2025
0xtj24
commented
- Add tests to use NAV instead of Fixed Price
- Add USDe before maturity feed with NAV and tests
wavey0x
reviewed
Mar 14, 2025
| uint80 answeredInRound | ||
| ) = sUSDeFeed.latestRoundData(); | ||
|
|
||
| uint256 sUSDeToUSDeRate = sUSDe.convertToAssets(1e18); |
There was a problem hiding this comment.
if token is capable of taking withdraw fees, .previewRedeem() may be more accurate
wavey0x
reviewed
Mar 14, 2025
| int256 USDeUsdPrice = (sUSDePrice * 1e18) / int256(sUSDeToUSDeRate); | ||
|
|
||
| (,int256 navDiscountedPrice,,,)= navFeed.latestRoundData(); | ||
| int256 usdeDiscountPrice = (USDeUsdPrice * navDiscountedPrice) / 1e18; |
There was a problem hiding this comment.
i believe this particular token is subject to a cooldown.
thus, a simple share price formula may be a somewhat misleading way to get the actual market price as the market should theoretically apply a discount based on time it takes to cool down.
just wanted to highlight this note, though i'm sure you've already considered.
wavey0x
approved these changes
Mar 14, 2025
…iRM into feat/pt-sude
Author
|
Already merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.