This repository was archived by the owner on Sep 9, 2025. It is now read-only.
[m3] Add performance notes to Keccak lookedup implementation#812
Open
HiddenAndBound wants to merge 1 commit intomainfrom
Open
[m3] Add performance notes to Keccak lookedup implementation#812HiddenAndBound wants to merge 1 commit intomainfrom
HiddenAndBound wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jimpo
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Add documentation to clarify that the lookedup Keccak implementation is primarily for benchmarking purposes, not for production use.
What changed?
Keccakfstruct documentation recommending the stacked version for production useHow to test?
No functional changes were made, so no testing is required. The documentation can be verified by reviewing the updated comments in the code.
Why make this change?
This change helps users understand the intended purpose of the lookedup Keccak implementation and guides them toward using the more performant stacked version for production use cases. The additional comments also make the code more maintainable by explaining the purpose of the lookup-based AND operation and how the merged values are constructed for the lookup table.