This repository was archived by the owner on Sep 9, 2025. It is now read-only.
feat: add ColumnId to WitnessBorrow and WitnessBorrowMut errors#831
Open
DeVikingMark wants to merge 2 commits intoIrreducibleOSS:mainfrom
Open
feat: add ColumnId to WitnessBorrow and WitnessBorrowMut errors#831DeVikingMark wants to merge 2 commits intoIrreducibleOSS:mainfrom
DeVikingMark wants to merge 2 commits intoIrreducibleOSS:mainfrom
Conversation
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses TODO comment in error.rs by adding ColumnId information to witness borrow errors for better debugging.
Changes