Cherry pick lazy pool init from swagger-codegen #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that very new Python versions are triggering a trackback in self.pool.close() for the __del__ method of the ApiClient class. Since the OneFS API doesn't use the async methods, this change should avoid the problem.
|
This issue seems to still exist in the new SDKs, can this be merged into the newer SDK that is scheduled to be released with 9.12? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that very new Python versions are triggering a trackback in self.pool.close() for the del method of the ApiClient class. Since the OneFS API doesn't use the async methods, this change should avoid the problem.
Please let me know if I should add a version bump here too.