[MOB-11764] Fix JWT refresh timer race condition on app background #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E, and include build/test scripts
…date test class and method references from `IterableApiTest` to `IterableKeychainTest`.- Ensure full package paths are used in test commands for consistency.- Simplify test result parsing logic in `agent_test.sh`.- Enhance error reporting for failed builds and tests.- Improve README instructions for running specific tests.
…sh` to `build.sh` and `agent_test.sh` to `test.sh` for uniformity.- Updated all references in documentation and scripts.
…eal-time progress display for Gradle tasks and tests.- Improve test filtering with wildcard support.- Include detailed logging for test events and exceptions.- Simplify build task output and handle build status.- Refactor cleanup and error handling for robustness.
…ensure JWT token refresh timer is cleared when app goes to background.- Ensure synchronization to prevent race conditions during timer operations.- Verify
- Synchronize scheduleAuthTokenRefresh and clearRefreshTimer methods - Prevents race condition when null JWT schedules retry timer but app backgrounds immediately - Ensures timer creation and clearing are atomic operations - Add test case to verify fix works correctly Fixes MOB-11764
|
@sumeruchat , is this branch and PR also for solving the same JWT in background issue? Should we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Customer reported JWT refresh timer not being cleared when app goes to background after null JWT token is returned, potentially causing hanging timers and unnecessary retry attempts.
Root Cause
Race condition between:
scheduleAuthTokenRefresh()(executor thread) - schedules retry timer when JWT returns nullclearRefreshTimer()(activity lifecycle thread) - clears timer on app backgroundIf app backgrounds immediately after null JWT response, timer creation and clearing could race, leaving uncanceled timers.
Solution
scheduleAuthTokenRefresh()andclearRefreshTimer()methodsisTimerScheduledvisible for testing with@VisibleForTestingTesting
✅ New test:
testNullJWTRefreshTimerRaceConditionOnBackground✅ All auth tests pass (24/24)
✅ Full test suite passes (200+ tests)
✅ No regressions
Manual Test Case
Impact
Fixes MOB-11764