Skip to content

[MOB-11427] Add maxWidth to getInAppMessages payload #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

pauljung14
Copy link
Contributor

@pauljung14 pauljung14 commented May 13, 2025

JIRA Ticket(s) if any

Description

  • Adds maxWidth as an optional parameter to be passed into getInAppMessages.

No maxWidth:
Screenshot 2025-05-13 at 3 25 16 PM

With 300px maxWidth:
Screenshot 2025-05-13 at 3 25 52 PM

Test Steps

  • Verify that in-browser messages render properly without maxWidth param.
  • Verify that in-browser messages render properly with maxWidth param (respects the max width set).

@pauljung14 pauljung14 requested a review from mprew97 as a code owner May 13, 2025 19:19
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (9907ed5) to head (9d78757).

Files with missing lines Patch % Lines
src/inapp/utils.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files          47       47           
  Lines        1784     1787    +3     
  Branches      565      566    +1     
=======================================
+ Hits         1157     1159    +2     
+ Misses        626      588   -38     
- Partials        1       40   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1,4 +1,3 @@
/* eslint-disable no-use-before-define */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some types have just been reordered bc it's an easy resolution of this lint error

bottomOffset,
rightOffset,
maxWidth
}: PaintIframeProps): Promise<HTMLIFrameElement> =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move jsdocs for params to PaintIframeProps in types.ts

@pauljung14 pauljung14 changed the title [MOB-11427] Add maxWidth to getinappmessages payload [MOB-11427] Add maxWidth to getInAppMessages payload May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants