-
Notifications
You must be signed in to change notification settings - Fork 9
[MOB-11427] Add maxWidth to getInAppMessages payload #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 64.85% 64.85%
=======================================
Files 47 47
Lines 1784 1787 +3
Branches 565 566 +1
=======================================
+ Hits 1157 1159 +2
+ Misses 626 588 -38
- Partials 1 40 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1,4 +1,3 @@ | |||
/* eslint-disable no-use-before-define */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some types have just been reordered bc it's an easy resolution of this lint error
bottomOffset, | ||
rightOffset, | ||
maxWidth | ||
}: PaintIframeProps): Promise<HTMLIFrameElement> => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move jsdocs for params to PaintIframeProps
in types.ts
JIRA Ticket(s) if any
Description
No maxWidth:

With 300px maxWidth:

Test Steps