Mob 11032 retry policy & auth failure i os #724
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SDK now implemented onAuthFailure on native bridge. It converts the Authfailure object to WriteableMap - TS layer AuthLayer is pending
- Linting in java file - Removal of encryptionEnforced - AuthFailure in Index - AuthFailure as a new interface type - New return type for IterableAuthFailure by authHandler - This needs to be revisited - failureCallback now comes with authFailure object in jwt - IterableAuthFailure use in Iterable.ts - sendEvent from RNAPIModule.java now sends the correct event.
New Handler method onJWTError introduced and flow of handleAuthFailureCalled is simplified
RN app should be able to pass RetryPolicy in configuration. iOS part is still pending.
Swift SDK pointing to 6.5.11 Updated AuthDelegate methods implemented Converting authfailure to dictionary and sending event as is to AuthFailure listener on TS side. Pending changes: 1. Authfailure enum to pass common values. Currently iOS is passing AuthFailurereason enum raw value. Need to pass in values which are being used in TS layer. 2. RetryPolicy to be in place
❌ 34 blocking issues (34 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| maxRetry: 5, | ||
| retryInterval: 10, | ||
| retryBackoff: IterableRetryBackoffType.LINEAR | ||
| } |
Comment on lines
+160
to
+161
| console.log('!!!Auth is being requested!!! and app is going to pass null'); | ||
| return Promise.resolve({authToken:"SomethingNotValid"}); |
There was a problem hiding this comment.
Replace '!!!Auth·is·being·requested!!!·and·app·is·going·to·pass·null' with ⏎··········'!!!Auth·is·being·requested!!!·and·app·is·going·to·pass·null'⏎········ [eslint:prettier/prettier]
Suggested change
| console.log('!!!Auth is being requested!!! and app is going to pass null'); | |
| return Promise.resolve({authToken:"SomethingNotValid"}); | |
| console.log( | |
| '!!!Auth is being requested!!! and app is going to pass null' | |
| ); |
|
|
||
| config.authHandler = () => { | ||
| console.log('!!!Auth is being requested!!! and app is going to pass null'); | ||
| return Promise.resolve({authToken:"SomethingNotValid"}); |
| config.authHandler = () => { | ||
| console.log('!!!Auth is being requested!!! and app is going to pass null'); | ||
| return Promise.resolve({authToken:"SomethingNotValid"}); | ||
| } |
| } | ||
|
|
||
| config.onJWTError = (err: IterableAuthFailure) => { | ||
| console.log('!!!JWT Error!!! '+ err.failureReason.toString(), err); |
| export * from './IterableEventName'; | ||
| export * from './IterableLogLevel'; | ||
| export * from './IterablePushPlatform'; | ||
| export * from './IterableRetryBackoffType'; |
| @@ -0,0 +1,18 @@ | |||
| import type { IterableAuthFailureReason } from "../enums/IterableAuthFailureReason"; | |||
There was a problem hiding this comment.
Found 2 issues:
1. Replace "../enums/IterableAuthFailureReason" with '../enums/IterableAuthFailureReason' [eslint:prettier/prettier]
2. Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]
Suggested change
| import type { IterableAuthFailureReason } from "../enums/IterableAuthFailureReason"; | |
| import type { IterableAuthFailureReason } from '../enums/IterableAuthFailureReason'; |
| @@ -0,0 +1,17 @@ | |||
| import { IterableRetryBackoffType } from '../enums/IterableRetryBackoffType'; | |||
There was a problem hiding this comment.
| /** Number of consecutive JWT refresh retries the SDK should attempt */ | ||
| maxRetry: number; | ||
| /** | ||
| * Duration between JWT refresh retries in seconds |
| retryInterval: number; | ||
| /** The backoff pattern to apply between retry attempts */ | ||
| retryBackoff: IterableRetryBackoffType; | ||
| } No newline at end of file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description