[MOB-12264] Add sync messages and get messages to android #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lposen
changed the base branch from
loren/embedded/MOB-12263-android-add-ability-to-sync-embedded-messages
to
loren/embedded/MOB-12265-start-end-session
|
|
Diff Coverage: The code coverage on the diff in this pull request is 0.0%. Total Coverage: This PR will decrease coverage by 0.56%. File Coverage Changes
🛟 Help
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
2 new issues
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java
Show resolved
Hide resolved
Comment on lines
+686
to
+718
| public void getEmbeddedMessages(@Nullable ReadableArray placementIds, Promise promise) { | ||
| IterableLogger.d(TAG, "getEmbeddedMessages for placements: " + placementIds); | ||
|
|
||
| try { | ||
| List<IterableEmbeddedMessage> allMessages = new ArrayList<>(); | ||
|
|
||
| if (placementIds == null || placementIds.size() == 0) { | ||
| // If no placement IDs provided, we need to get messages for all possible placements | ||
| // Since the Android SDK requires a placement ID, we'll use 0 as a default | ||
| // This might need to be adjusted based on the actual SDK behavior | ||
| List<IterableEmbeddedMessage> messages = IterableApi.getInstance().getEmbeddedManager().getMessages(0L); | ||
| if (messages != null) { | ||
| allMessages.addAll(messages); | ||
| } | ||
| } else { | ||
| // Convert ReadableArray to individual placement IDs and get messages for each | ||
| for (int i = 0; i < placementIds.size(); i++) { | ||
| long placementId = placementIds.getInt(i); | ||
| List<IterableEmbeddedMessage> messages = IterableApi.getInstance().getEmbeddedManager().getMessages(placementId); | ||
| if (messages != null) { | ||
| allMessages.addAll(messages); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| JSONArray embeddedMessageJsonArray = Serialization.serializeEmbeddedMessages(allMessages); | ||
| IterableLogger.d(TAG, "Messages for placements: " + embeddedMessageJsonArray); | ||
|
|
||
| promise.resolve(Serialization.convertJsonToArray(embeddedMessageJsonArray)); | ||
| } catch (JSONException e) { | ||
| IterableLogger.e(TAG, e.getLocalizedMessage()); | ||
| promise.reject("", "Failed to fetch messages with error " + e.getLocalizedMessage()); | ||
| } |
lposen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description