Add response version getter (e.g. "HTTP/1.1")#37
Merged
Conversation
Enhances HTTP response handling by adding version information. Updated the process_request function to include HTTP version in responses and added a new function to retrieve the HTTP version as a string. Modified related types and FFI interface accordingly.
- Introduced a new 'list' command to display available just tasks. - Added a 'format' command to run cargo fmt for code formatting.
- added VI to call the shared library function to get http version - added basic building of "HTTP/1.1 200" string (but no reason like "OK")
jimkring
changed the title
Contributor
Author
|
This is effectively "good enough" and we can leave figuring out if/how to handle the reason phrase for later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances HTTP response handling by adding version information.
Todo:
Future tasks:
OKinHTTP/1.1 200 OK) which went away inHTTP/2and is not accessible via the reqwest crate's API