feat: add the ability to delete devices#201
Open
benjaminmikiten wants to merge 3 commits into
Open
Conversation
- Add try-catch error handling to removeDevice store action to catch and log IPC errors - Add toast error notification in DeviceView when delete fails - Fix delete button disabled state to only disable during active sync phases (preparing, copying, verifying), not after sync completes (done, error) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
benjaminmikiten
force-pushed
the
bm-support-deleting-devices
branch
from
efbd1e0 to
32d0d3f
Compare
Author
|
Thanks for reviewing this PR! I've been building something similar myself, and I was very impressed with what you've built here. |
benjaminmikiten
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This implements deleting devices from ROMie.
This was implemented with claude using
superpowers, and reviewed by a human engineer.Why?
In testing this I realized after creating a device that I wanted to reconfigure it with a custom profile, but wasn't able to delete it.
How to test