Refactor CitationKeyGeneratorTest to use parameterized tests #14133
+401
−297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs JabRef#676
Refactored
CitationKeyGeneratorTestto use parameterized tests with@ParameterizedTestand@MethodSource, reducing code duplication while maintaining test coverage.Collaboration: This refactoring was completed in collaboration with my classmate @hisunll. We divided the work - she refactored the first half of the test class, and I refactored the second half.
Note: My classmates are also contributing to fixing this issue as part of our CS5010 coursework. cc @espertusnu
Steps to test
This is a test refactoring PR with no functional changes to the application.
./gradlew test --tests CitationKeyGeneratorTestMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)