Feature parse MeSH terms in PubMed MEDLINE records by LoayTarek5 · Pull Request #15529 · JabRef/jabref

LoayTarek5 · 2026-04-11T07:53:37Z

Related issues and pull requests

PR Description

Parse MeSH terms in Medline/PubMed importers (XML and Plain Text) into individual heading/qualifier pairs with major topic markers, matching PubMed's display format.

Steps to test

1- Download PubMed format, then save as a .txt file
2- In JabRef, go to File -> Import, select the saved file
3- Click the imported entry, go to the General tab, and check the Keywords field
You should see individual keyword chips matching PubMed's display format.
4- for XML import open for example https://eutils.ncbi.nlm.nih.gov/entrez/eutils/efetch.fcgi db=pubmed&id=23633646&retmode=xml -> right-click -> Save as .xml
6- In JabRef, File → Import → select the file (choose "Medline/PubMed" format)
7-Go to General tab -> check Keywords field

.txt

.xml

The full keywords: Female; Graves Disease/radiotherapy*; Humans; Hypothyroidism/etiology*; Iodine Radioisotopes/adverse effects; Iodine Radioisotopes/therapeutic use*; Retrospective Studies; Thyrotoxicosis/radiotherapy*; Thyroxine/blood; Treatment Failure; Weight Gain

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[/] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

…ajor topic flag and update qualifier name handling

…e keyword handling for descriptors and qualifiers

…ualifierName record for improved MeSH term handling

…ainImporter

qodo-free-for-open-source-projects · 2026-04-11T07:54:00Z

Review Summary by Qodo

Parse MeSH terms into individual heading/qualifier pairs

✨ Enhancement

Walkthroughs

Description

• Parse MeSH terms into individual heading/qualifier pairs with major topic markers
• Update MeshHeading record to track descriptor major flag and qualifier details
• Refactor keyword formatting to use slash-separated heading/qualifier syntax
• Add test coverage for MeSH term parsing in plain text importer

Diagram

flowchart LR
  A["MeSH Term Input<br/>e.g. *Kidney/diagnosis"] --> B["Parse Descriptor<br/>and Qualifiers"]
  B --> C["Extract Major<br/>Topic Flags"]
  C --> D["Format Keywords<br/>heading/qualifier*"]
  D --> E["Individual Keyword<br/>Chips in UI"]

File Changes

1. jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlineImporter.java ✨ Enhancement +17/-8

Enhanced MeSH term parsing with major topic flags

• Extract descriptorMajor flag from DescriptorName MajorTopicYN attribute
• Create MeshHeading.QualifierName records to store qualifier name and major flag
• Refactor addMeshHeading() to format keywords as descriptor/qualifier* pairs
• Add asterisk suffix for major topic descriptors and qualifiers

jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlineImporter.java

2. jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java ✨ Enhancement +45/-7

Add MeSH term parsing for plain text format

• Implement parseMeshTerm() method to split compound MeSH terms into individual keywords
• Handle major topic markers (asterisk prefix) for descriptors and qualifiers
• Separate handling of MH (MeSH) and OT (other terms) fields
• Format keywords as descriptor/qualifier* pairs matching PubMed display format

jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java

3. jablib/src/main/java/org/jabref/logic/importer/fileformat/medline/MeshHeading.java ✨ Enhancement +4/-1

Extend MeshHeading record with major topic tracking
• Add descriptorMajor boolean field to track major topic flag
• Change qualifierNames from List<String> to List<QualifierName>
• Introduce nested QualifierName record with name and major flag fields
jablib/src/main/java/org/jabref/logic/importer/fileformat/medline/MeshHeading.java

View more (4)

4. jablib/src/test/java/org/jabref/logic/importer/fileformat/MedlinePlainImporterTest.java 🧪 Tests +18/-0

Add test for MeSH term parsing functionality
• Add test meshTermsAreParsedIntoIndividualKeywords() to verify MeSH term parsing
• Test compound term splitting with major topic markers
• Verify correct keyword formatting with slash separators and asterisks
jablib/src/test/java/org/jabref/logic/importer/fileformat/MedlinePlainImporterTest.java

5. jablib/src/test/resources/org/jabref/logic/importer/fileformat/MedlineImporterTestNbib.bib 🧪 Tests +1/-1

Update test fixture for new keyword format
• Update expected keywords to use new slash-separated format with major topic markers
• Change from comma-separated qualifiers to heading/qualifier* syntax
jablib/src/test/resources/org/jabref/logic/importer/fileformat/MedlineImporterTestNbib.bib

6. jablib/src/test/resources/org/jabref/logic/importer/fileformat/MedlinePlainImporterTestCompleteEntry.bib 🧪 Tests +1/-1

Update test fixture for new keyword format
• Update expected keywords to match new slash-separated format
• Adjust major topic asterisk placement to qualifier position
jablib/src/test/resources/org/jabref/logic/importer/fileformat/MedlinePlainImporterTestCompleteEntry.bib

7. CHANGELOG.md 📝 Documentation +1/-0

Document MeSH term parsing improvement
• Add entry documenting improved MeSH term parsing in Medline/PubMed importers
• Reference issue #12532
CHANGELOG.md

qodo-free-for-open-source-projects · 2026-04-11T07:54:01Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (1) 🎨 UX Issues (0)

📎\ ≡ Correctness (1)

1. No MH separator conflict check 📎 ≡

Description

The updated MH import path serializes parsed MeSH keywords using the configured keyword separator
without detecting whether that separator occurs inside the raw MH value. If the separator appears
in an MH line, the resulting keywords field can become ambiguous or corrupted without any
warning/substitution.

Code

jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[R193-199]

+                    case "MH" -> {
+                        List<String> meshKeywords = parseMeshTerm(value);
+                        Character separator = importFormatPreferences.bibEntryPreferences().getKeywordSeparator();
+                        String meshString = String.join(separator + " ", meshKeywords);
+                        fieldConversionMap.merge(StandardField.KEYWORDS, meshString,
+                                (existing, newVal) -> existing + separator + " " + newVal);
+                    }

Evidence
PR Compliance ID 5 requires detecting conflicts when the user-defined keyword separator appears in
MH input lines. The new MH handling joins parsed tokens using the configured separator but
neither checks value for the separator nor applies any warning/substitution strategy in
parseMeshTerm.
Detect and handle conflicts when the user-defined keyword separator appears in PubMed MH input lines
jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[193-199]
jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[407-435]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The MEDLINE plain-text importer serializes `MH`-derived keywords using the configured keyword separator but does not detect when that same separator character appears inside the raw `MH` value, which can lead to ambiguous/corrupted keyword boundaries.
## Issue Context
Compliance requires checking `MH  - ...` lines for the user-defined keyword separator and either warning the user or applying a safe substitution/escaping strategy before serialization.
## Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[193-199]
- jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[407-435]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Test uses setField ☑ 📘 ⚙

Description

The newly added test constructs the expected BibEntry using mutable setField calls rather than
the preferred withField withers. This violates the project’s test construction conventions and
reduces consistency with the rest of the test suite.

Code

jablib/src/test/java/org/jabref/logic/importer/fileformat/MedlinePlainImporterTest.java[R127-131]

+            BibEntry expectedEntry = new BibEntry();
+            expectedEntry.setField(StandardField.PMID, "12345678");
+            expectedEntry.setField(StandardField.KEYWORDS,
+                    "Kidney Diseases*/diagnosis, Kidney Diseases*/epidemiology, Female, some other term");
+

Evidence
PR Compliance ID 40 requires using BibEntry withers (withField) instead of setField in
tests/construction. The added test uses expectedEntry.setField(...) for both PMID and
KEYWORDS.
AGENTS.md
jablib/src/test/java/org/jabref/logic/importer/fileformat/MedlinePlainImporterTest.java[127-131]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A newly added unit test constructs `BibEntry` using `setField`, but project conventions require using `withField` for test construction/modification.
## Issue Context
Using `withField` keeps tests consistent with JabRef’s preferred immutable-style `BibEntry` usage.
## Fix Focus Areas
- jablib/src/test/java/org/jabref/logic/importer/fileformat/MedlinePlainImporterTest.java[127-131]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

qodo-free-for-open-source-projects · 2026-04-11T07:59:58Z

+                    case "MH" -> {
+                        List<String> meshKeywords = parseMeshTerm(value);
+                        Character separator = importFormatPreferences.bibEntryPreferences().getKeywordSeparator();
+                        String meshString = String.join(separator + " ", meshKeywords);
+                        fieldConversionMap.merge(StandardField.KEYWORDS, meshString,
+                                (existing, newVal) -> existing + separator + " " + newVal);
+                    }


1. No mh separator conflict check 📎 Requirement gap ≡ Correctness

The updated MH import path serializes parsed MeSH keywords using the configured keyword separator without detecting whether that separator occurs inside the raw MH value. If the separator appears in an MH line, the resulting keywords field can become ambiguous or corrupted without any warning/substitution.

Agent Prompt

## Issue description The MEDLINE plain-text importer serializes `MH`-derived keywords using the configured keyword separator but does not detect when that same separator character appears inside the raw `MH` value, which can lead to ambiguous/corrupted keyword boundaries. ## Issue Context Compliance requires checking `MH - ...` lines for the user-defined keyword separator and either warning the user or applying a safe substitution/escaping strategy before serialization. ## Fix Focus Areas - jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[193-199] - jablib/src/main/java/org/jabref/logic/importer/fileformat/MedlinePlainImporter.java[407-435]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

This was intentionally scoped out in the discussion of issue #12532.
Keyword separator escaping is handled in #12810 (resolved PR #14637)

…ecords

calixtus · 2026-04-15T07:25:19Z

Can you take a look @ryan-carpenter?

faneeshh · 2026-04-16T21:14:46Z

You could add a test for the XML importer's MeSH parsing. Everything else looks good to me.

LoayTarek5 added 7 commits April 11, 2026 09:23

Enhance MeSH term parsing in Medline/PubMed importers

401253b

Refactor MeSH term parsing in MedlineImporter to include descriptor m…

23c32b0

…ajor topic flag and update qualifier name handling

Refactor MedlinePlainImporter to enhance MeSH term parsing and improv…

7712e51

…e keyword handling for descriptors and qualifiers

Refactor MeshHeading to include descriptor major flag and introduce Q…

e777e48

…ualifierName record for improved MeSH term handling

Add test for parsing MeSH terms into individual keywords in MedlinePl…

4a7a6d2

…ainImporter

Update keywords to use MeSH term formatting

e059338

correct MeSH term formatting in keywords

f3bb5c7

github-actions bot added component: groups component: fetcher component: keywords component: import-load labels Apr 11, 2026

qodo-free-for-open-source-projects bot reviewed Apr 11, 2026

View reviewed changes

github-actions bot added the status: changes-required Pull requests that are not yet complete label Apr 11, 2026

Parse MeSH terms into individual heading/qualifier keyword pairs

976ad32

github-actions bot mentioned this pull request Apr 11, 2026

Parse MeSH terms in PubMed MEDLINE records #12532

Open

LoayTarek5 and others added 2 commits April 11, 2026 10:32

Fix expected keywords in MathML test fixture

3a019f6

Merge branch 'main' into feature-Parse-MeSH-terms-in-PubMed-MEDLINE-r…

8c01253

…ecords

github-actions bot added status: no-bot-comments and removed status: changes-required Pull requests that are not yet complete labels Apr 11, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature parse MeSH terms in PubMed MEDLINE records#15529

Feature parse MeSH terms in PubMed MEDLINE records#15529
LoayTarek5 wants to merge 10 commits intoJabRef:mainfrom
LoayTarek5:feature-Parse-MeSH-terms-in-PubMed-MEDLINE-records

LoayTarek5 commented Apr 11, 2026

Uh oh!

qodo-free-for-open-source-projects bot commented Apr 11, 2026

Uh oh!

qodo-free-for-open-source-projects bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects bot Apr 11, 2026

Uh oh!

LoayTarek5 Apr 11, 2026

Uh oh!

Uh oh!

calixtus commented Apr 15, 2026

Uh oh!

faneeshh commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

LoayTarek5 commented Apr 11, 2026

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects bot commented Apr 11, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

qodo-free-for-open-source-projects bot Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

LoayTarek5 Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

calixtus commented Apr 15, 2026

Uh oh!

faneeshh commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qodo-free-for-open-source-projects bot commented Apr 11, 2026 •

edited

Loading