Notify observers if anything changes #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to fact that onChanged() method responds only to notifyDataSetChanged() call, other calls (notifyItemChanged, notifyItemMoved, etc..) are left hanging. Observer has to be notified if any (and all) of those calls are invoked.
|
Maybe it makes sense to have an event object, that would reflect the type of change that occurred? |
|
Idk whether that's necessary. Until now it wasn't supposed to reflect anything; just alert the subscriber that dataset changed which is by this commit extended for all dataset changes. However I'm not saying that's bad idea. |
|
I'd rather have granular notifications for these available via a different overload. |
|
Do you mean something like supplying observer with some enum of state that has changed? Or absolutely different approach? |
|
We use auto value classes since each callback has to carry data. See item
selected / nothing selected for a spinner for an example.
…On Wed, Jun 28, 2017 at 1:22 PM viktor de pasquale ***@***.***> wrote:
Do you mean something like supplying observer with some enum of state that
has changed? Or absolutely different approach?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#390 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEbLl40McOayaReJVvCLPocR9Nl2cks5sIovWgaJpZM4N5v3H>
.
|
Make dataChanges return T wrapped in event that presumably occurred. Classes *Event (base), *ChangeEvent, *RangeChangeEvent, *InsertionEvent, *RemovalEvent, *MoveEvent have been created to distinct events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to fact that onChanged() method responds only to notifyDataSetChanged() call, other calls (notifyItemChanged, notifyItemMoved, etc..) are left hanging. Observer has to be notified if any (and all) of those calls are invoked.
And I'm sorry for the import misplacement.