Skip to content

Cmake - pkgconfig and installation files #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhidalgocarrio wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Cmake - pkgconfig and installation files #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b67a016
cmake: option to build static/dynamic library. include installation o…
Dec 12, 2016
5af3eb7
cmake: use variable for the installation path
Dec 13, 2016
98a6ca3
cmake: option for pkgconfig in the compilation process
Dec 13, 2016
a0c6df7
cmake: dso comes with its own version of Sophus. This makes the insta…
Dec 13, 2016
91fe9ae
cmake: install IOWrapper headers
Dec 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
94 changes: 91 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ set(BUILD_TYPE Release)

set(EXECUTABLE_OUTPUT_PATH bin)
set(LIBRARY_OUTPUT_PATH lib)
set(INCLUDE_OUTPUT_PATH include/dso)
set(CMAKE_OUTPUT_PATH ${LIBRARY_OUTPUT_PATH}/cmake/dso)
Copy link
Collaborator

@NikolausDemmel NikolausDemmel Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMAKE_OUTPUT_PATH seems unused. Did you have plans to include a DSOConfig.cmake DSOConfigVersion.cmake as well?

Copy link
Author

@jhidalgocarrio jhidalgocarrio Aug 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle I don't plan to create those files right now but it can be done in a following step.
Are you suggesting to remove CMAKE_OUTPUT_PATH in order to merge this PR?

Copy link
Collaborator

@NikolausDemmel NikolausDemmel Sep 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly just wondering why it is there, if it is unused.

Copy link
Author

@jhidalgocarrio jhidalgocarrio Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Good question. I think is because I had in mind to create a FindDSO.cmake file (sorry it was some time ago).

set(PKGCONFIG_OUTPUT_PATH ${LIBRARY_OUTPUT_PATH}/pkgconfig)
set(CMAKE_MODULE_PATH ${PROJECT_SOURCE_DIR}/cmake)

# required libraries
Expand All @@ -30,6 +33,11 @@ set(CMAKE_CXX_FLAGS
"${SSE_FLAGS} -O3 -g -std=c++0x -march=native"
# "${SSE_FLAGS} -O3 -g -std=c++0x -fno-omit-frame-pointer"
)
option(DSO_BUILD_STATIC_LIBRARY "Build a static dso library, instead of shared" ON)

if(NOT WIN32)
option(DSO_BUILD_PKGCONFIG "Build pkg-config .pc file for DSO" ON)
endif(NOT WIN32)

# Sources files
set(dso_SOURCE_FILES
Expand All @@ -53,7 +61,7 @@ set(dso_SOURCE_FILES
${PROJECT_SOURCE_DIR}/src/util/globalCalib.cpp
)


set(DSO_BOOST_LIBRARIES ${Boost_SYSTEM_LIBRARY} ${Boost_THREAD_LIBRARY})

include_directories(
${PROJECT_SOURCE_DIR}/src
Expand Down Expand Up @@ -106,9 +114,27 @@ endif()


# compile main library.
include_directories( ${CSPARSE_INCLUDE_DIR} ${CHOLMOD_INCLUDE_DIR})
add_library(dso ${dso_SOURCE_FILES} ${dso_opencv_SOURCE_FILES} ${dso_pangolin_SOURCE_FILES})
include_directories( ${CSPARSE_INCLUDE_DIR} ${CHOLMOD_INCLUDE_DIR})

if (DSO_BUILD_STATIC_LIBRARY)
message("--- dso static library selected.")
add_library(dso ${dso_SOURCE_FILES} ${dso_opencv_SOURCE_FILES} ${dso_pangolin_SOURCE_FILES})
install (TARGETS dso ARCHIVE DESTINATION ${LIBRARY_OUTPUT_PATH} COMPONENT libraries)
else()
message("--- dso dynamic library selected.")
add_library(dso SHARED ${dso_SOURCE_FILES} ${dso_opencv_SOURCE_FILES} ${dso_pangolin_SOURCE_FILES})
target_link_libraries(dso boost_system boost_thread cxsparse)
if (HAS_ZIPLIB)
target_link_libraries(dso ${LIBZIP_LIBRARY})
endif()
if (HAS_PANGOLIN)
target_link_libraries(dso ${Pangolin_LIBRARIES})
endif()
if (HAS_OPENCV)
target_link_libraries(dso ${OpenCV_LIBS})
endif()
install (TARGETS dso LIBRARY DESTINATION ${LIBRARY_OUTPUT_PATH} COMPONENT libraries)
endif()
#set_property( TARGET dso APPEND_STRING PROPERTY COMPILE_FLAGS -Wall )


Expand All @@ -121,3 +147,65 @@ else()
message("--- not building dso_dataset, since either don't have openCV or Pangolin.")
endif()

file(GLOB dso_HEADER_FILES "${PROJECT_SOURCE_DIR}/src/FullSystem/*.h")

install (FILES ${dso_HEADER_FILES} DESTINATION ${INCLUDE_OUTPUT_PATH}/FullSystem)

file(GLOB dso_HEADER_FILES "${PROJECT_SOURCE_DIR}/src/OptimizationBackend/*.h")

install (FILES ${dso_HEADER_FILES} DESTINATION ${INCLUDE_OUTPUT_PATH}/OptimizationBackend)

file(GLOB dso_HEADER_FILES "${PROJECT_SOURCE_DIR}/src/IOWrapper/*.h")

install (FILES ${dso_HEADER_FILES} DESTINATION ${INCLUDE_OUTPUT_PATH}/IOWrapper)

file(GLOB dso_HEADER_FILES "${PROJECT_SOURCE_DIR}/src/util/*.h")

install (FILES ${dso_HEADER_FILES} DESTINATION ${INCLUDE_OUTPUT_PATH}/util)

#DSO comes with its own version of Sophus (TODO try to get the library from https://github.com/strasdat/Sophus)
file(GLOB SOPHUS_HEADER_FILES "${PROJECT_SOURCE_DIR}/thirdparty/Sophus/sophus/*.hpp")
install (FILES ${SOPHUS_HEADER_FILES} DESTINATION ${INCLUDE_OUTPUT_PATH}/sophus)

macro(libraries_for_pkgconfig VARNAME)
foreach(__lib ${ARGN})
string(STRIP __lib ${__lib})
string(SUBSTRING ${__lib} 0 1 __lib_is_absolute)
if (__lib_is_absolute STREQUAL "/")
get_filename_component(__lib_path ${__lib} PATH)
get_filename_component(__lib_name ${__lib} NAME_WE)
string(REGEX REPLACE "^lib" "" __lib_name "${__lib_name}")
set(${VARNAME} "${${VARNAME}} -L${__lib_path} -l${__lib_name}")
else()
set(${VARNAME} "${${VARNAME}} ${__lib}")
endif()
endforeach()
endmacro()

# Generate pkgconfig pc file
if(DSO_BUILD_PKGCONFIG)
if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/dso.pc.in)
message("-- Found: ${CMAKE_CURRENT_SOURCE_DIR}/dso.pc.in")

# Set the target name
set(TARGET_NAME dso)

# Dependency for DSO
libraries_for_pkgconfig(${TARGET_NAME}_PKGCONFIG_LIBS
${DSO_BOOST_LIBRARIES} ${LIBZIP_LIBRARY} ${Pangolin_LIBRARIES}
${OpenCV_LIBS})

set(${TARGET_NAME}_PKGCONFIG_CFLAGS "${${TARGET_NAME}_PKGCONFIG_CFLAGS} ${BOOST_CFLAGS_OTHER}")

set(PKGCONFIG_REQUIRES eigen3)
set(PKGCONFIG_CFLAGS ${${TARGET_NAME}_PKGCONFIG_CFLAGS})
set(PKGCONFIG_LIBS ${${TARGET_NAME}_PKGCONFIG_LIBS})

configure_file(dso.pc.in dso.pc @ONLY)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/dso.pc DESTINATION ${PKGCONFIG_OUTPUT_PATH})
else()
message("-- pkg-config: ${CMAKE_CURRENT_SOURCE_DIR}/dso.pc.in is not available for configuration")
endif()

endif(DSO_BUILD_PKGCONFIG)

11 changes: 11 additions & 0 deletions dso.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=@CMAKE_INSTALL_PREFIX@
libdir=${prefix}/@LIBRARY_OUTPUT_PATH@
includedir=${prefix}/@INCLUDE_OUTPUT_PATH@

Name: @TARGET_NAME@
Description: @TARGET_NAME@
Version: @DSO_VERSION_STRING@
Requires: @PKGCONFIG_REQUIRES@
Libs: -L${libdir} -l@TARGET_NAME@ @PKGCONFIG_LIBS@
Cflags: -I${includedir} @PKGCONFIG_CFLAGS@