Put the ffmpeg process in a setTimeout#126
Open
karimmakhloufi wants to merge 1 commit intoJamesKyburz:mainfrom
Open
Put the ffmpeg process in a setTimeout#126karimmakhloufi wants to merge 1 commit intoJamesKyburz:mainfrom
karimmakhloufi wants to merge 1 commit intoJamesKyburz:mainfrom
Conversation
To avoid the maximum call stack range error when multiple simultaneous calls are made or even when used in a cue with only 1 worker. I did time it and a 1h30 video and did not see any performance drop karim@karim-laptop ~/Work/streamtube/xp time node index.js node index.js 52,42s user 3,99s system 112% cpu 50,100 total karim@karim-laptop ~/Work/streamtube/xp time node index.js node index.js 52,34s user 4,13s system 115% cpu 48,956 total
|
Have you tested on the real server yet. I try ec2 aws amazon build and it often stops. Is there a way to fix it. |
Author
|
I've only tried it on heroku and on my laptop for now, I'll try on ec2 to reproduce. |
JamesKyburz
force-pushed
the
main
branch
3 times, most recently
from
62c3a4e to
0199a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid the maximum call stack range error when multiple simultaneous calls are made or even when used in a cue with only 1 worker.
I did time it and a 1h30 video and did not see any performance drop
karim@karim-laptop ~/Work/streamtube/xp time node index.js
node index.js 52,42s user 3,99s system 112% cpu 50,100 total
karim@karim-laptop ~/Work/streamtube/xp time node index.js
node index.js 52,34s user 4,13s system 115% cpu 48,956 total