Skip to content

fix(jans-cedarling): bump sidecar cedarling-python - #15761

Merged
moabu merged 1 commit into
mainfrom
sidecar-cedarling-2-5-22
Nov 19, 2026
Merged

moabu merged 1 commit into
mainfrom
sidecar-cedarling-2-5-22

Conversation

@mo-auto

@mo-auto mo-auto commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Bumps cedarling-python in the Flask sidecar from 2.5.21 to 2.5.22, the first release that reads policy-store spec v2 trusted-issuers.json. The image installs with uv sync --locked, so the lockfile is bumped too.

Not tested locally: wheels are Linux x86_64 only.
Closes #15762,

2.5.21 cannot read policy-store spec v2 trusted-issuers.json;
2.5.22 is the first release that can.

Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
Signed-off-by: moauto <54212639+mo-auto@users.noreply.github.com>
@mo-auto mo-auto added kind-bug Issue or PR is a bug in existing functionality comp-jans-cedarling Touching folder /jans-cedarling labels Nov 19, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mo-auto

mo-auto commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Flask sidecar raises the minimum required version of cedarling-python from 2.5.21 to 2.5.22.

Changes: cedarling-python version update

Layer / File(s) Summary
Update dependency minimum
jans-cedarling/flask-sidecar/pyproject.toml
The minimum required cedarling-python version changes from 2.5.21 to 2.5.22.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

  • JanssenProject/jans#15510: This PR previously raised the cedarling-python minimum in the same Flask sidecar from 2.5.16 to 2.5.21.

Suggested reviewers: 0xtinkle, moabu

Merge Risk: Minimal · up to 83dc2

This dependency bump lets the Flask sidecar read policy-store spec v2 trusted-issuers.json. No concrete merge-blocking risk was found. The author did not test locally because wheels exist only for Linux x86_64.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The author describes the change clearly. It bumps cedarling-python in the Flask sidecar from 2.5.21 to 2.5.22, and the lockfile is updated because the image installs with uv sync --locked. The descrip… Use the repository template. Add the Prepare checklist items. Complete the Target issue section with a valid reference such as 'closes #15762'. Add Implementation Details, even if brief. Address the Test and Document the changes checklist. …
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the change: bumping the cedarling-python dependency in the jans-cedarling Flask sidecar. The diff raises the minimum version from 2.5.21 to 2.5.22 in pyproject.toml, so the title match…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: bumping the cedarling-python dependency in the jans-cedarling Flask sidecar. The diff raises the minimum version from 2.5.21 to 2.5.22 in pyproject.toml, so the title matches the main change. The 'fix' type prefix is a judgment call, since the change is a dependency bump, but the title still describes the change accurately.

Full details: Description check

Explanation

The author describes the change clearly. It bumps cedarling-python in the Flask sidecar from 2.5.21 to 2.5.22, and the lockfile is updated because the image installs with uv sync --locked. The description does not follow the repository template. It omits the Prepare checklist, the Target issue section with a complete issue reference, the Implementation Details section, and the Test and Document the changes checklist. The docs confirmation checkbox is also absent. The closing line reads 'Closes #15762,' which has a trailing comma and is not a valid closing reference in the expected form.

Resolution

Use the repository template. Add the Prepare checklist items. Complete the Target issue section with a valid reference such as 'closes #15762'. Add Implementation Details, even if brief. Address the Test and Document the changes checklist. State the reason tests were not run locally (Linux x86_64-only wheels) under the test item. Add the docs impact confirmation checkbox and state whether a commit starting with 'docs:' is needed.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c7f13368-5350-4fb0-840d-3b766e2bf2ab
Commits

Reviewing files that changed from the base of the PR and between 2a6f511 and 83dc2b4.

Files ignored due to path filters: 1

  • jans-cedarling/flask-sidecar/uv.lock is excluded by !**/*.lock
Files selected for processing: 1

  • jans-cedarling/flask-sidecar/pyproject.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@mo-auto

mo-auto commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Error: Hi @mo-auto, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

@moabu
moabu merged commit 218e009 into main Nov 19, 2026
42 of 43 checks passed
@moabu
moabu deleted the sidecar-cedarling-2-5-22 branch November 19, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-jans-cedarling Touching folder /jans-cedarling kind-bug Issue or PR is a bug in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: fix(jans-cedarling): bump sidecar cedarling-python -autocreated

2 participants