Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Add fbref link#427

Open
aymennasri wants to merge 1 commit into
JaseZiv:mainfrom
aymennasri:main
Open

Add fbref link#427
aymennasri wants to merge 1 commit into
JaseZiv:mainfrom
aymennasri:main

Conversation

@aymennasri
Copy link
Copy Markdown
Contributor

@aymennasri aymennasri commented Mar 31, 2025

@tonyelhabr I tried to mimic the same edits made in the last pkgdown website update in this commit, the github action pkgdown should take care of the rest.

@aymennasri aymennasri changed the title Add fbref link (attempt to update the pkgdown website) Attempt to update the pkgdown website Mar 31, 2025
@tonyelhabr
Copy link
Copy Markdown
Contributor

ah, you know, that pkgdown Github action has been running on every merge to main. it seems the issue blocking rebuilds of the site has been with a function call

Reading vignettes/load-scraped-data.Rmd
Error in `.f()`:
! Failed to render 'vignettes/load-scraped-data.Rmd'.
✖ Quitting from load-scraped-data.Rmd:178-197 [load_fb_advanced_match_stats]
Caused by error:
! Can't combine `..1$Home_Score` <character> and `..2$Home_Score` <double>.
Backtrace:
     ▆
  1. ├─worldfootballR::load_fb_advanced_match_stats(...)
  2. │ └─purrr::map_dfr(urls, .file_reader)
  3. │   └─dplyr::bind_rows(res, .id = .id)
  4. │     └─vctrs::vec_rbind(!!!dots, .names_to = .id, .error_call = current_env())
  5. └─vctrs (local) `<fn>`()
  6.   └─vctrs::vec_default_ptype2(...)
  7.     ├─base::withRestarts(...)
  8.     │ └─base (local) withOneRestart(expr, restarts[[1L]])
  9.     │   └─base (local) doWithOneRestart(return(expr), restart)
 10.     └─vctrs::stop_incompatible_type(...)
 11.       └─vctrs:::stop_incompatible(...)
 12.         └─vctrs:::stop_vctrs(...)
 13.           └─rlang::abort(message, class = c(class, "vctrs_error"), ..., call = call)
 14.

@aymennasri aymennasri changed the title Attempt to update the pkgdown website Add fbref link Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants