Skip to content

temporary font files are not always be purged in multi threaded server environments like wildfly #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markus-graf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

temporary font files are not always be purged in multi threaded server environments like wildfly #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions jasperreports/src/net/sf/jasperreports/engine/fonts/AwtFontManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,19 @@ public class AwtFontManager

private static final Log log = LogFactory.getLog(AwtFontManager.class);

private static final AwtFontManager INSTANCE = new AwtFontManager();

private static class InstanceHolder {
private static final AwtFontManager INSTANCE = new AwtFontManager();
}

public static AwtFontManager instance()
{
return INSTANCE;
return InstanceHolder.INSTANCE;
}
private Map<FontFileReference, Object> fontFileReferences;
private ReferenceQueue<Font> fontFilesQueue;
public AwtFontManager()

private final Map<FontFileReference, Object> fontFileReferences;
private final ReferenceQueue<Font> fontFilesQueue;

private AwtFontManager()
{
fontFileReferences = new ConcurrentHashMap<>();
fontFilesQueue = new ReferenceQueue<>();
Expand Down Expand Up @@ -117,17 +119,18 @@ public void purgeFontFiles()
FontFileReference fontFileRef;
while ((fontFileRef = (FontFileReference) fontFilesQueue.poll()) != null)
{
fontFileReferences.remove(fontFileRef);

try
{
Files.deleteIfExists(fontFileRef.fontFile);
if (Files.deleteIfExists(fontFileRef.fontFile)) {
log.debug("Font file '" + fontFileRef.fontFile + "' successfully deleted.");
}
fontFileReferences.remove(fontFileRef);
}
catch (IOException e)
{
if (log.isDebugEnabled())
{
log.debug("Failed to delete font file " + fontFileRef.fontFile);
log.debug("Failed to delete font file '" + fontFileRef.fontFile + "' due to IOException " + e.getMessage());
}
}
}
Expand Down