support ellipse, rectangle, line as shapes in xls, xlsx, ods export #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozawa-hi
changed the title
ozawa-hi
changed the title
Author
|
Tested on MS Office 2007, Google Docs, Spreadsheet and were able to open and view xls, xlsx, and pptx generated files without problem. Need to work on docx format. Probaby better to have property to output in original format for uses who do not want to output shapes. |
Author
|
I'm merging this pull request with the overlapping shapes pull request. |
|
Has this been added as a feature to production? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to show ellipse as a shape instead of cell borders in xls export. Need further fix to support ellipse in xlsx and xls metadata.