various bugs fixed

JerryI · Feb 24, 2025 · 9ffcd9e · 9ffcd9e
1 parent a536ebe
commit 9ffcd9e
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 16 deletions.
diff --git a/Components/Notifications/Components/Custom.wlx b/Components/Notifications/Components/Custom.wlx
@@ -7,6 +7,7 @@ CreateType[Notifications`Custom(*`*), init, {"Topic"->"Title", "Icon" -> With[{}
 
 (*/* Might be an issue since this component it imported multiple times, could rewrite definitions */*)
 
+Echo["Notifications >> Created custom notifications type"];
 
 init[n_] := With[{dom = CreateUUID[]},
     Echo["Created! Spinner"];

diff --git a/Components/Notifications/Components/Spinner.wlx b/Components/Notifications/Components/Spinner.wlx
@@ -2,6 +2,8 @@ CreateType[Notifications`Spinner(*`*), init, {"Topic"->"Title", "Promise"->Null,
 
 (*/* Might be an issue since this component it imported multiple times, could rewrite definitions */*)
 
+Echo["Notifications >> Created spinner notifications type"];
+
 init[n_] := With[{dom = CreateUUID[]},
     Echo["Created! Spinner"];
     n["DOM"] = dom;

diff --git a/Components/Notifications/Notifications.wlx b/Components/Notifications/Notifications.wlx
@@ -9,10 +9,10 @@ CreateType[NotificationsDialog, initDialog, {"Message"->"Dummy", "Event"->Null}]
 
 ImportComponent["Components/Types.wl"];
 
-MessageList  = ImportComponent["Components/MessagesList.wlx"]; 
-{SpinnerTemplate, SpinnerScript}  = ImportComponent["Components/Spinner.wlx"]; 
-CustomTemplate                    = ImportComponent["Components/Custom.wlx"]; 
-{GenericTemplate, GenericScript}  = ImportComponent["Components/Generic.wlx"]; 
+MessageList  = Once[ImportComponent["Components/MessagesList.wlx"]]; 
+{SpinnerTemplate, SpinnerScript}  = Once[ImportComponent["Components/Spinner.wlx"]]; 
+CustomTemplate                    = Once[ImportComponent["Components/Custom.wlx"]]; 
+{GenericTemplate, GenericScript}  = Once[ImportComponent["Components/Generic.wlx"]]; 
 
 
 Filter[_]               = False

diff --git a/README.md b/README.md
@@ -113,6 +113,15 @@ Export entire notebooks as standalone `.html` files, retaining all embedded data
 ### **Wolfram Engine**
 [Download Wolfram Engine](https://www.wolfram.com/engine/) (Version 13.3+ recommended). Activation is required after installation.
 
+#### Tested
+- Wolfram Engine 13.1 (no copilot)
+- Wolfram Engine 13.2 (no copilot)
+- Wolfram Engine 13.3 (no copilot)
+- Wolfram Engine 13.4 (no copilot)
+- Wolfram Engine 14.0
+- Wolfram Engine 14.1
+- Wolfram Engine 14.2
+
 **macOS Installation via Homebrew:**
 ```shell
 brew install --cask wolfram-engine
@@ -121,10 +130,6 @@ brew install --cask wolfram-engine
 ### **WLJS Notebook App ✨**
 Download from the **[releases](https://github.com/JerryI/wolfram-js-frontend/releases)** section.
 
-#### Normal vs Offline Version
-- The __offline version__ includes fixed versions of modules, documentation, and examples.
-- The __normal version__ fetches the latest updates from GitHub upon installation.
-
 #### CLI Installation
 WLJS Notebook provides a CLI tool. You can open a folder in WLJS Notebook with:
 ```bash

diff --git a/Views/Notebook/Components/Dropdown.wlx b/Views/Notebook/Components/Dropdown.wlx
@@ -1,4 +1,4 @@
-Component[OptionsPattern[]] := With[{Color = (If[StringQ[#], #, "teal"]&) @ OptionValue["Parameters"]["AccentColor"], Event = OptionValue["Event"], ExtesionInjector = OptionValue["ExtesionInjector"]},
+Component[OptionsPattern[]] := With[{Messager = OptionValue["Messager"],  Color = (If[StringQ[#], #, "teal"]&) @ OptionValue["Parameters"]["AccentColor"], Event = OptionValue["Event"], ExtesionInjector = OptionValue["ExtesionInjector"]},
   EventHandler[Event, {
     "CallDropdown" -> ((Print["CallDropdown!"]; WebUISubmit[Global`UICellsDropdown[#], Global`$Client])&)
   }];
@@ -18,7 +18,7 @@ Component[OptionsPattern[]] := With[{Color = (If[StringQ[#], #, "teal"]&) @ Opti
             </svg>
               Project to a window
             </button>
-            <ExtesionInjector Template={"CellDropdown-Section-1"} Event={Event}/>
+            <ExtesionInjector Template={"CellDropdown-Section-1"} Messager={Messager} Event={Event}/>
         </div>
         ,
           <div class="py-0 px-2" role="none">
@@ -29,7 +29,7 @@ Component[OptionsPattern[]] := With[{Color = (If[StringQ[#], #, "teal"]&) @ Opti
             </svg>
               Make initialization cell
             </button>
-            <ExtesionInjector Template={"CellDropdown-Section-2"} Event={Event}/>
+            <ExtesionInjector Template={"CellDropdown-Section-2"} Messager={Messager} Event={Event}/>
           </div>
 ,
           <div class="py-0 px-2" role="none">
@@ -99,6 +99,7 @@ Component[OptionsPattern[]] := With[{Color = (If[StringQ[#], #, "teal"]&) @ Opti
 
             for (let i=0; i<buttons.length; i++) {
                 const el = buttons[i];
+                if (!el.dataset.name) continue;
                 el.addEventListener('click', () => {
                     server.emitt('<Event/>', '"'+currentCell+'"', el.dataset.name);
                 });
@@ -126,7 +127,7 @@ Component[OptionsPattern[]] := With[{Color = (If[StringQ[#], #, "teal"]&) @ Opti
   ]
 ];
 
-Options[Component] = {"Event"->"", "Parameters"->Null, "ExtesionInjector"->( "" &)};
+Options[Component] = {"Event"->"", "Messager"->"", "Parameters"->Null, "ExtesionInjector"->( "" &)};
 
 Script = "";
 

diff --git a/Views/Notebook/Notebook.wlx b/Views/Notebook/Notebook.wlx
@@ -891,9 +891,7 @@ Component[OptionsPattern[]] := With[{
 
         ],
 
-        "Evaluate" -> Function[celluid, evaluateCell[cell`HashMap[celluid](*`*), notebook, secret, log, kernels, $Client, modals, parameters, extensions]],
-
-        else_ :> (Echo[StringTemplate["Unknown notebook view event ``: ``"][else, #]]&)
+        "Evaluate" -> Function[celluid, evaluateCell[cell`HashMap[celluid](*`*), notebook, secret, log, kernels, $Client, modals, parameters, extensions]]
     }];
 
     With[{nid = notebook["Hash"]},
@@ -907,7 +905,7 @@ Component[OptionsPattern[]] := With[{
             </ExtensionTemplateWrapper>
             <ExtensionTemplateInjection Template={"Notebook-Epilog"} Notebook={notebook} Event={secret} />
 
-            <CellDropdown Parameters={parameters} Event={secret} ExtesionInjector={ExtensionTemplateInjection}/>
+            <CellDropdown Parameters={parameters} Messager={log} Event={secret} ExtesionInjector={ExtensionTemplateInjection}/>
             <ElectronBinds Event={secret} Controls={controller}/>
 
             <ExtensionTemplateInjection Template={"Footer"} Modals={modals} Messager={log} Notebook={notebook} Event={secret} Controls={controller}/>