KG-597: Fix serialization crashes and optimize content parsing #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aozherelyeva
requested review from
EugeneTheDev,
antoniibelyshev and
sdubov
and removed request for
EugeneTheDev,
antoniibelyshev and
sdubov
WorldOfBasti
force-pushed
the
bastian.aunkofer/fix-serialization-errors
branch
2 times, most recently
from
6d96ea0 to
fd79c50
Compare
WorldOfBasti
force-pushed
the
bastian.aunkofer/fix-serialization-errors
branch
from
fd79c50 to
9f5bada
Compare
EugeneTheDev
requested changes
Jan 14, 2026
Collaborator
EugeneTheDev
left a comment
EugeneTheDev
left a comment
There was a problem hiding this comment.
Thank you, generally looks good, a few comments
...nts-core/src/commonMain/kotlin/ai/koog/agents/core/environment/ContextualAgentEnvironment.kt
Outdated
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/message/Message.kt
Show resolved
Hide resolved
prompt/prompt-model/src/commonMain/kotlin/ai/koog/prompt/streaming/StreamFrame.kt
Outdated
Show resolved
Hide resolved
.../koog/prompt/executor/clients/bedrock/modelfamilies/amazon/BedrockAmazonNovaSerialization.kt
Show resolved
Hide resolved
EugeneTheDev
requested changes
Jan 14, 2026
Collaborator
EugeneTheDev
left a comment
EugeneTheDev
left a comment
There was a problem hiding this comment.
I've also noticed a number of wrong imports, can you please fix these? Other than that looks good
| import ai.koog.agents.core.tools.Tool | ||
| import ai.koog.prompt.message.ContentPart | ||
| import ai.koog.prompt.message.Message | ||
| import io.ktor.utils.io.CancellationException |
Collaborator
There was a problem hiding this comment.
nit: wrong CancellationException
Author
There was a problem hiding this comment.
Good catch, I missed those. Fixed them in the latest commit!
| import ai.koog.agents.core.feature.model.toAgentError | ||
| import ai.koog.prompt.message.Message | ||
| import io.github.oshai.kotlinlogging.KotlinLogging | ||
| import io.ktor.utils.io.CancellationException |
Collaborator
There was a problem hiding this comment.
nit: wrong CancellationException
| import ai.koog.prompt.message.Message | ||
| import ai.koog.prompt.params.LLMParams | ||
| import ai.koog.prompt.processor.ResponseProcessor | ||
| import io.ktor.utils.io.CancellationException |
Collaborator
There was a problem hiding this comment.
nit: wrong CancellationException
| import ai.koog.agents.snapshot.providers.PersistenceStorageProvider | ||
| import ai.koog.prompt.message.Message | ||
| import io.github.oshai.kotlinlogging.KotlinLogging | ||
| import io.ktor.utils.io.CancellationException |
Collaborator
There was a problem hiding this comment.
nit: wrong CancellationException
| import io.ktor.server.engine.EmbeddedServer | ||
| import io.ktor.server.engine.EngineConnectorConfig | ||
| import io.ktor.server.engine.embeddedServer | ||
| import io.ktor.utils.io.CancellationException |
Collaborator
There was a problem hiding this comment.
nit: wrong CancellationException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds robust error handling for tool argument parsing, result serialization, and subgraph tool execution failures. Instead of crashing, the agent should now handle these errors and return failure results.
Issue also described in KG-597 / #1169
Changes
Tool Argument Parsing errors
onToolValidationFailedcallback and return aToolResultKind.ValidationErrorwith an error message instead of crashingTool result serialization errors
decodeResult()Result.Failurewith an error messageSubgraph finish tool hanlding
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature