-
Notifications
You must be signed in to change notification settings - Fork 301
[WIP] chore: Refactor gradle configurations #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Make `integration-tests` java module, without Dokka - Use "ai.kotlin.jvm.published" for http-client-java,http-client-okhttp, http-client-test
72e0c4f to
d66257e
Compare
|
|
||
| plugins { | ||
| id("ai.kotlin.jvm") | ||
| id("ai.kotlin.jvm.publish") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid, it was not published before
|
|
||
| plugins { | ||
| id("ai.kotlin.multiplatform.server") | ||
| id("ai.kotlin.jvm") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make integration tests simple JVM module
|
|
||
| plugins { | ||
| id("ai.kotlin.jvm") | ||
| id("ai.kotlin.jvm.publish") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid, it was not published before
|
|
||
| plugins { | ||
| id("ai.kotlin.jvm") | ||
| id("ai.kotlin.jvm.publish") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid, it was not published before
|
|
||
| plugins { | ||
| kotlin("jvm") | ||
| id("ai.kotlin.configuration") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRY
| plugins { | ||
| kotlin("jvm") | ||
| id("ai.kotlin.configuration") | ||
| id("ai.kotlin.dokka") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to run Dokka if module isn't published
| sourceCompatibility = javaTarget | ||
| targetCompatibility = javaTarget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now 17
Qodana for JVM1378 new problems were found
@@ Code coverage @@
+ 71% total lines covered
18247 lines analyzed, 13044 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
chore: Refactor gradle configurations
integration-testsjava module, without DokkaMotivation and Context
Breaking Changes
JVM target is consistently 17
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature