Skip to content

Conversation

@kpavlov
Copy link
Contributor

@kpavlov kpavlov commented Jan 7, 2026

chore: Refactor gradle configurations

  • Make integration-tests java module, without Dokka
  • Consolidate Kotlin core library version configuration across plugins
  • Use "ai.kotlin.jvm.published" for http-client-java,http-client-okhttp, http-client-test
  • Align JVM target across projects: 17

Motivation and Context

  • Avoid running dokka when not needed
  • Run dokka and publish http-client-java,http-client-okhttp, http-client-test
  • Integraiton tests is JVM only, so no reason to keep it multiplatform

Breaking Changes

JVM target is consistently 17


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

- Make `integration-tests` java module, without Dokka
- Use "ai.kotlin.jvm.published" for http-client-java,http-client-okhttp, http-client-test
@kpavlov kpavlov changed the title chore: Migrate integration-tests to java module chore: Refactor gradle configurations Jan 7, 2026
@kpavlov kpavlov requested a review from aozherelyeva January 7, 2026 19:32

plugins {
id("ai.kotlin.jvm")
id("ai.kotlin.jvm.publish")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid, it was not published before


plugins {
id("ai.kotlin.multiplatform.server")
id("ai.kotlin.jvm")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make integration tests simple JVM module


plugins {
id("ai.kotlin.jvm")
id("ai.kotlin.jvm.publish")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid, it was not published before


plugins {
id("ai.kotlin.jvm")
id("ai.kotlin.jvm.publish")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid, it was not published before


plugins {
kotlin("jvm")
id("ai.kotlin.configuration")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DRY

plugins {
kotlin("jvm")
id("ai.kotlin.configuration")
id("ai.kotlin.dokka")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to run Dokka if module isn't published

Comment on lines +62 to +63
sourceCompatibility = javaTarget
targetCompatibility = javaTarget
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now 17

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Qodana for JVM

1378 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 1358
Missing KDoc for public API declaration 🔶 Warning 20
@@ Code coverage @@
+ 71% total lines covered
18247 lines analyzed, 13044 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@kpavlov kpavlov changed the title chore: Refactor gradle configurations [WIP] chore: Refactor gradle configurations Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants